Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add back camera support #180

Draft
wants to merge 16 commits into
base: feat/no-light-support
Choose a base branch
from
Draft

feat: add back camera support #180

wants to merge 16 commits into from

Conversation

thisisabhash
Copy link
Member

Issue #, if available:
None

Description of changes:
Back camera support for no light challenge

Check points: (check or cross out if not relevant)

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

thisisabhash added 16 commits July 1, 2024 10:26
@thisisabhash
feat: add no light challenge implementation (#127)
bc16192 
* feat: add no light challenge implementation

* update package.swift for CI build

* Fix unit tests

* Address review comments
@thisisabhash
chore: Add attempt count changes (#137)
e8643b7 
* chore: Add attempt count changes

* Fix unit tests

* add unit tests

* Update region for example liveness view

* Update amplify-swift dependency
@thisisabhash
chore: update dependencies after rebase
b22ef51
@thisisabhash
fix: handle error on loading view (#154)
49b620c
@thisisabhash
update test branch dependency and add code for choosing challenge type
f2e8a7e
@thisisabhash
chore: back camera support
7bc6928
@thisisabhash
Add code for error scenarios
6d82434
@thisisabhash
chore: update amplify dependency and add sample code to choose challe…
ef85f6c 
…nge type
@thisisabhash
update amplify dependency
861c368
@thisisabhash
resolve merge conflicts
afaf415
@thisisabhash
fix build
3e479bd
@thisisabhash
fix build
d74d878
@thisisabhash
update error codes and message
8e6c9d5
@thisisabhash
Add challengeOption parameter and remove error codes
b9a3aec
@thisisabhash
Update ChallengeOptions and use camera position based on challenge ty…
b746324 
…pe received
@thisisabhash
Add UI changes for selecting back camera in HostApp
bf516df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thisisabhash