Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update face fit instruction text and error message #49

Merged
merged 3 commits into from
Aug 30, 2023
Merged

chore: update face fit instruction text and error message #49

merged 3 commits into from
Aug 30, 2023

Conversation

phantumcode
Copy link
Member

@phantumcode phantumcode commented Aug 30, 2023 •
edited
Loading

Issue #, if available:

Description of changes:

  • Updating the face fit instruction text and remove references to time out duration
  • Updating error messages in host app and integration app and remove references to time out duration

Check points: (check or cross out if not relevant)

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@phantumcode phantumcode requested review from a team as code owners August 30, 2023 16:54
@phantumcode phantumcode merged commit 680bb19 into main Aug 30, 2023
1 check passed
@phantumcode phantumcode deleted the chore/text_cleanup branch August 30, 2023 21:16
phantumcode added a commit that referenced this pull request Aug 31, 2023
@phantumcode
Merge branch 'main' into release
f015e12 
* main:
  chore: update face fit instruction text and error message (#49)
  chore: refactor session fit timeout from backend service (#46)
  chore: provide more fine-grained websocket close code on errors (#44)
devedup pushed a commit to devedup/amplify-ui-swift-liveness that referenced this pull request Sep 12, 2023
@phantumcode @devedup
chore: update face fit instruction text and error message (aws-amplif…
3b794db 
…y#49)

* chore: clean up face fit instruction text

* chore: update face fit instruction text and error message

* chore: update face fit instruction text and error message
phantumcode added a commit that referenced this pull request Sep 12, 2023
@phantumcode
Merge branch 'main' into phantum/automation
e6fc1e4 
* main:
  chore: update face fit instruction text and error message (#49)
  chore: refactor session fit timeout from backend service (#46)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruisebas ruisebas ruisebas approved these changes

@atierian atierian atierian approved these changes

@thisisabhash thisisabhash thisisabhash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@phantumcode @thisisabhash @atierian @ruisebas