fix(Authenticator): clicking on current tab switches tabs (#5912)

* fix clicking on current tab switching tabs * use newRoute for route changing * Create brown-pumpkins-knock.md
aws-amplify · Oct 17, 2024 · 6fea94b · 6fea94b
1 parent d52a6f3
commit 6fea94b
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/.changeset/brown-pumpkins-knock.md b/.changeset/brown-pumpkins-knock.md
@@ -0,0 +1,5 @@
+---
+"@aws-amplify/ui-react": patch
+---
+
+fix(React/Authenticator): clicking on currently active tab no longer switches to the wrong tab
diff --git a/docs/next-env.d.ts b/docs/next-env.d.ts
diff --git a/packages/react/src/components/Authenticator/shared/SignInSignUpTabs.tsx b/packages/react/src/components/Authenticator/shared/SignInSignUpTabs.tsx
@@ -32,7 +32,11 @@ export const SignInSignUpTabs = ({
         <Tabs.Container
           value={route}
           isLazy
-          onValueChange={() => (route === 'signIn' ? toSignUp() : toSignIn())}
+          onValueChange={(newRoute) => {
+            if (newRoute !== route) {
+              newRoute === 'signIn' ? toSignIn() : toSignUp();
+            }
+          }}
         >
           <Tabs.List spacing="equal" indicatorPosition="top">
             <Tabs.Item value="signIn">{getSignInTabText()}</Tabs.Item>