Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(liveness): add clarification to Android liveness custom credentials provider #4726

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

tjleing
Copy link
Contributor

@tjleing tjleing commented Nov 14, 2023

Description of changes

Update Android Liveness docs to specify that custom credentials must be of type AWSTemporaryCredentials as mentioned in this issue.

Issue #, if available

Description of how you validated changes

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • Relevant documentation is changed or added (and PR referenced)
  • yarn test passes and tests are updated/added
  • No side effects or sideEffects field updated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tjleing tjleing requested a review from a team as a code owner November 14, 2023 21:38
Copy link

changeset-bot bot commented Nov 14, 2023

⚠️ No Changeset found

Latest commit: 734dd8c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@reesscot reesscot merged commit 193ca4b into main Nov 15, 2023
31 checks passed
@reesscot reesscot deleted the liveness-android-credentials-provider-info branch November 15, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants