feat(A.Next): add useQRCodeString for RN #4886
Conversation
|
...t-native-auth/src/hooks/useQRCodeString/__tests__/__snapshots__/useQRCodeString.spec.ts.snap
Show resolved
Hide resolved
| '^uuid$': '<rootDir>/../../node_modules/uuid', | ||
| }, | ||
| modulePaths: ['<rootDir>/node_modules/'], | ||
| coverageThreshold: { |
| }); | ||
|
|
||
| return () => { | ||
| ignore = true; |
There was a problem hiding this comment.
Is this because the hook can be unmounted before the async toQRCodeString completes?
| import { isFunction } from '@aws-amplify/ui'; | ||
|
|
||
| export type UseQRCodeStringParams = { | ||
| onError?: (err: string) => void; |
There was a problem hiding this comment.
Do we have a general pattern or philosophy on whether it should be onError?: (error: Error) => void; or onError?: (err: string) => void;?
There was a problem hiding this comment.
Good question 😄 We do not, for internal hooks personally have been leaning towards (errorMessage: string) => void for ease of use in client code but don't feel particularly strongly either way
Description of changes
Add
useQRCodeStringand unit tests for Totp configuration in RNAuthenticatorIssue #, if available
Description of how you validated changes
Checklist
yarn testpasses and tests are updated/addedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.