Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update liveness button focus border to have a gap #4895

Merged
merged 3 commits into from
Jan 10, 2024

Conversation

thaddmt
Copy link
Contributor

@thaddmt thaddmt commented Jan 9, 2024

Description of changes

Screenshot 2024-01-09 at 3 15 29 PM

Issue #, if available

Description of how you validated changes

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • Relevant documentation is changed or added (and PR referenced)
  • yarn test passes and tests are updated/added
  • No side effects or sideEffects field updated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@thaddmt thaddmt requested a review from a team as a code owner January 9, 2024 20:35
Copy link

changeset-bot bot commented Jan 9, 2024

🦋 Changeset detected

Latest commit: a69e935

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@aws-amplify/ui Patch
@aws-amplify/ui-react-auth Patch
@aws-amplify/ui-react-core-auth Patch
@aws-amplify/ui-react-core-notifications Patch
@aws-amplify/ui-react-core Patch
@aws-amplify/ui-react-liveness Patch
@aws-amplify/ui-react-native-auth Patch
@aws-amplify/ui-react-native Patch
@aws-amplify/ui-react-notifications Patch
@aws-amplify/ui-react-storage Patch
@aws-amplify/ui-react Patch
@aws-amplify/ui-vue Patch
@aws-amplify/ui-angular Patch
@aws-amplify/ui-react-geo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

esauerbo
esauerbo previously approved these changes Jan 9, 2024
Copy link
Contributor

@esauerbo esauerbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

hbuchel
hbuchel previously approved these changes Jan 9, 2024
Copy link
Contributor

@hbuchel hbuchel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit for the extra box-shadow declaration but otherwise LGTM

packages/ui/src/theme/css/component/liveness.scss Outdated Show resolved Hide resolved
@thaddmt thaddmt dismissed stale reviews from hbuchel and esauerbo via a69e935 January 9, 2024 23:53
@thaddmt thaddmt merged commit ad07069 into main Jan 10, 2024
33 checks passed
@thaddmt thaddmt deleted the liveness-button-focus branch January 10, 2024 00:16
@github-actions github-actions bot mentioned this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants