fix(web/react-native/ui): use translated strings and censorContactMethod for VerifyUser screen #5034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d6f1adc The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
hbuchel
commented
Feb 27, 2024
| class="amplify-flex amplify-radio" | ||
| data-amplify-verify-label | ||
| id="verify" | ||
| <template |
There was a problem hiding this comment.
It looks like "value" could potentially be undefined based on the type, so I wrapped the radio options in a <template v-if>. Not sure if this is the best fix for that?
Additionally, I re-ordered the elements because the radio circle was showing after the label text and removed the duplicated "verify" id
hbuchel
commented
Feb 27, 2024
hbuchel
changed the title
hbuchel
commented
Feb 28, 2024
hbuchel
commented
Feb 28, 2024
hbuchel
commented
Feb 28, 2024
hbuchel
changed the title
packages/vue/src/components/__tests__/__snapshots__/authenticator.spec.ts.snap
Outdated
Show resolved
Hide resolved
reesscot
approved these changes
Feb 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes an issue on the VerifyUser screen in Vue where the verification options were not getting properly translated and displayed. I copied the same method from our React library. I moved the censorContactInformation utility to the
uipackage and updates usage across Angular, Vue, React and React Native.React
No visual change, just refactored to use the censorContactInformation that is now exported from
uipackageAfter
Angular
Angular's translations weren't broken, but it wasn't showing the censored contact information like in React.
Vue
Vue was not showing the correct translations, nor the censored contact info. Additionally, the radio was rendering after the text and there was a repeated
idon the inputs and wrapping label elements. Since ids must be unique and we're not relying on them (and any customer relying on them would likely have encountered unexpected/broken results), I removed them.React Native
No visual change, verified via VerifyUser snapshot test.
Left some comments inline.
Issue #, if available
Fixes #4986
Description of how you validated changes
Tested in vue example app using my own aws-exports for a email/phone sign in. Then I manually unverified my user's email/phone and attempted to login to view the verification screen (screenshots above).
Checklist
yarn testpasses and tests are updated/addedsideEffectsfield updatedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.