Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): add storage-browser offline tests #6206

Merged
merged 7 commits into from
Jan 10, 2025
Merged

Conversation

ashwinkumar6
Copy link
Member

@ashwinkumar6 ashwinkumar6 commented Nov 25, 2024

Description of changes

Add offline e2e tests for action menu items

Description of how you validated changes

Tested in cypress locally
Screenshot 2025-01-08 at 1 22 00 PM

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • yarn test passes and tests are updated/added
  • PR title and commit messages follow conventional commit syntax
  • If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ashwinkumar6 ashwinkumar6 requested a review from a team as a code owner November 25, 2024 21:40
Copy link

changeset-bot bot commented Nov 25, 2024

⚠️ No Changeset found

Latest commit: fd6ba66

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

ashika112
ashika112 previously approved these changes Nov 26, 2024
ashika112
ashika112 previously approved these changes Jan 8, 2025
Copy link
Member

@calebpollman calebpollman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these!

@ashwinkumar6 ashwinkumar6 merged commit f575deb into main Jan 10, 2025
35 checks passed
@ashwinkumar6 ashwinkumar6 deleted the e2e-offline-tests branch January 10, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants