-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(IoT): Fixing a race condition when invalidating/creating the reconnect timer #5454
Open
ruisebas
wants to merge
1
commit into
main
Choose a base branch
from
fix/iot-crash
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruisebas
temporarily deployed
to
IntegrationTest
October 25, 2024 21:41
— with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
October 25, 2024 21:41
— with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
October 25, 2024 21:41
— with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
October 25, 2024 21:41
— with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
October 25, 2024 21:41
— with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
October 25, 2024 21:41
— with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
October 25, 2024 21:41
— with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
October 25, 2024 21:41
— with
GitHub Actions
Inactive
ruisebas
had a problem deploying
to
IntegrationTest
October 25, 2024 21:41
— with
GitHub Actions
Failure
ruisebas
temporarily deployed
to
IntegrationTest
October 25, 2024 21:41
— with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
October 25, 2024 21:41
— with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
October 25, 2024 21:41
— with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
October 25, 2024 21:41
— with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
October 25, 2024 21:41
— with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
October 25, 2024 21:41
— with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
October 25, 2024 21:41
— with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
October 25, 2024 21:41
— with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
October 25, 2024 21:41
— with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
October 25, 2024 21:41
— with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
October 25, 2024 21:41
— with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
October 25, 2024 21:41
— with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
October 25, 2024 21:41
— with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
October 25, 2024 21:41
— with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
October 25, 2024 21:41
— with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
October 25, 2024 21:41
— with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
October 26, 2024 18:58
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The
reconnectTimer
property is created in thetimerQueue
queue, but it can be invalidated and set tonil
in the main queue inside thecleanupReconnectTimer
method.See the issue for a more detailed analysis and explanation by @AndrKonovalov
Check points:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.