-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Hooks #861
Merged
Brianwithay21
merged 5 commits into
aws-cloudformation:master
from
Brianwithay21:HooksPrGithub
Feb 10, 2022
Merged
Add support for Hooks #861
Brianwithay21
merged 5 commits into
aws-cloudformation:master
from
Brianwithay21:HooksPrGithub
Feb 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatMyron
reviewed
Feb 9, 2022
This was referenced Feb 9, 2022
benbridts
reviewed
Feb 10, 2022
src/rpdk/core/data/schema/provider.configuration.definition.schema.hooks.v1.json
Outdated
Show resolved
Hide resolved
src/rpdk/core/data/schema/provider.configuration.definition.schema.hooks.v1.json
Outdated
Show resolved
Hide resolved
src/rpdk/core/data/schema/provider.configuration.definition.schema.hooks.v1.json
Show resolved
Hide resolved
…hema.hooks.v1.json Co-authored-by: Ben Bridts <[email protected]>
…hema.hooks.v1.json Co-authored-by: Ben Bridts <[email protected]>
JeremySB
approved these changes
Feb 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
wkexiang
approved these changes
Feb 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
kddejong
pushed a commit
to kddejong/cloudformation-cli
that referenced
this pull request
Oct 24, 2022
* Added support for Hooks * Bump version to 0.2.23 * Removed unused unsupported target hook contract test * Update src/rpdk/core/data/schema/provider.configuration.definition.schema.hooks.v1.json Co-authored-by: Ben Bridts <[email protected]> * Update src/rpdk/core/data/schema/provider.configuration.definition.schema.hooks.v1.json Co-authored-by: Ben Bridts <[email protected]> Co-authored-by: Ben Bridts <[email protected]>
kddejong
pushed a commit
to kddejong/cloudformation-cli
that referenced
this pull request
Oct 24, 2022
* Added support for Hooks * Bump version to 0.2.23 * Removed unused unsupported target hook contract test * Update src/rpdk/core/data/schema/provider.configuration.definition.schema.hooks.v1.json Co-authored-by: Ben Bridts <[email protected]> * Update src/rpdk/core/data/schema/provider.configuration.definition.schema.hooks.v1.json Co-authored-by: Ben Bridts <[email protected]> Co-authored-by: Ben Bridts <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release adds support for creating Hooks using the CFN CLI
cfn init --artifact-type HOOK --type-name <type-name>
cfn init --artifact-type HOOK --type-name My::Test::Example
cfn init
without parameters will now first ask if you want to create a resource, module, or a hook. If you choose to create a hook, you will be asked to choose a language plugin. After choosing a plugin, a hook project will be generated with boilerplate code which you can use as a starting point to make your changes.cfn validate
to validate your hook before submittingcfn submit
to register your hook, making it available for use by CloudFormation in your AWS accountRelated PRs:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.