fix: stackId not setable during 'cfn invoke' testing of RESOURCE #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammokhov
requested changes
Oct 11, 2023
| @@ -110,6 +110,7 @@ def invoke(args): | |||
| request["desiredResourceState"], | |||
| request["previousResourceState"], | |||
| request.get("typeConfiguration"), | |||
| stackId=request.get("stackId") | |||
There was a problem hiding this comment.
Stack id is not always present, as this is purely CloudFormation concept. Resource Handlers are also used by CloudControl, which does not provide value for this field. I would prefer to left it out of cfn invoke payload.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Fixes: #998
Description of changes:
stackIdduringcfn invokeif it is included in the request JSONBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.