Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(examples): temporarily fix SAR version to v2.x #5360

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

dreamorosi
Copy link
Contributor

@dreamorosi dreamorosi commented Oct 10, 2024

Issue number: #5359

Summary

Changes

Please provide a summary of what's being changed

Customers have reported that the SAR version in the docs incorrectly states the latest version available is 3.x. This is not the case, and we are still working on publishing the latest major release on SAR (we are tracking this in #5221).

This PR temporarily reverts the version number change to the latest v2x to avoid confusion.

Once v3 is published in SAR, we'll update the docs accordingly.

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Oct 10, 2024
@dreamorosi dreamorosi requested a review from a team as a code owner October 10, 2024 12:46
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 10, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 10, 2024
@dreamorosi dreamorosi linked an issue Oct 10, 2024 that may be closed by this pull request
1 task
@leandrodamascena leandrodamascena changed the title docs: temporarily fix SAR version to v2.x docs(examples): temporarily pin SAR version to v2.x Oct 10, 2024
@leandrodamascena leandrodamascena changed the title docs(examples): temporarily pin SAR version to v2.x docs(examples): temporarily fix SAR version to v2.x Oct 10, 2024
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @dreamorosi!

Copy link

sonarcloud bot commented Oct 10, 2024

@leandrodamascena leandrodamascena merged commit cdea7ee into develop Oct 10, 2024
4 checks passed
@leandrodamascena leandrodamascena deleted the docs/sar_ branch October 10, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: SAR lambda layer documentation uses incorrect version of Powertools
2 participants