Fixed defect when AWS region was not set for core addon version look-up #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…up despite an explicit setting on the blueprint. Resolves #1015
shapirov103
requested review from
aws-ia-ci,
parkand1,
youngjeong46,
elamaran11 and
a team
as code owners
|
/do-e2e-tests |
aws-ia-ci
requested changes
Jul 15, 2024
…ion as per current state of AWS describe-addon-versions API
|
/do-e2e-tests |
elamaran11
reviewed
Jul 16, 2024
synth.log
Outdated
| @@ -0,0 +1,1324 @@ | |||
|
|
|||
| > @aws-quickstart/[email protected] examples | |||
There was a problem hiding this comment.
What is this file? Why is this added to PR?
There was a problem hiding this comment.
removed, good catch.
elamaran11
reviewed
Jul 16, 2024
test/cloudwatch-insights.test.ts
Outdated
| @@ -3,6 +3,7 @@ import * as blueprints from '../lib'; | |||
| import {CloudWatchInsightsAddOnProps, Values} from "../lib"; | |||
| import {Match, Template} from "aws-cdk-lib/assertions"; | |||
| import {KubernetesVersion} from "aws-cdk-lib/aws-eks"; | |||
| import { add } from 'lodash'; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
despite an explicit setting on the blueprint. Resolves #1015
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.