fix(aws-lb-controller): wait till deployed #1102
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
AlbController
webhook isn't ready directly after the AddOn deployment.This cause a race condition when another AddOn creates Kubernetes Manifest resources that rely on it, like
TargetGroupBinding
.Sometimes it is successful, sometimes not. To avoid such situations,
addHelmChart
ofAlbController
should wait similar as it was implemented forExternal Secrets
: #514Example of such an error when the proposed fix is not applied:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.