Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-lb-controller): wait till deployed #1102

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

wombelix
Copy link
Contributor

@wombelix wombelix commented Nov 6, 2024

Issue #, if available:

N/A

Description of changes:

AlbController webhook isn't ready directly after the AddOn deployment.
This cause a race condition when another AddOn creates Kubernetes Manifest resources that rely on it, like TargetGroupBinding.
Sometimes it is successful, sometimes not. To avoid such situations, addHelmChart of AlbController should wait similar as it was implemented for External Secrets: #514

Example of such an error when the proposed fix is not applied:

Received response status [FAILED] from custom resource. Message returned: Error: b'Error from server (InternalError): error when creating "/tmp/manifest.yaml": Internal error occurred:
failed calling webhook "mtargetgroupbinding.elbv2.k8s.aws": failed to call webhook: Post "https://aws-load-balancer-webhook-service.kube-system.svc:443/mutate-elbv2-k8s-aws-v1beta1-tar
getgroupbinding?timeout=10s": no endpoints available for service "aws-load-balancer-webhook-service"\n'

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Collaborator

@shapirov103 shapirov103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shapirov103
Copy link
Collaborator

/do-e2e-tests

Copy link

@aws-ia-ci aws-ia-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end to end tests failed. A maintainer can provide more details.

@shapirov103
Copy link
Collaborator

/do-e2e-tests

Copy link

@aws-ia-ci aws-ia-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end to end tests failed. A maintainer can provide more details.

@shapirov103
Copy link
Collaborator

validated locally, requires dependency on vpc cni to provide repeatable and reliable results.

@shapirov103 shapirov103 dismissed aws-ia-ci’s stale review December 24, 2024 15:52

Debugged and verified locally

@shapirov103 shapirov103 merged commit 6c0e113 into aws-quickstart:main Dec 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants