Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to Komodor addon #593

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Link to Komodor addon #593

merged 1 commit into from
Jul 17, 2023

Conversation

ronahk
Copy link
Contributor

@ronahk ronahk commented Feb 1, 2023

Description of changes:
Adding link to Komodor addon.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Collaborator

@youngjeong46 youngjeong46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment.

mkdocs.yml Show resolved Hide resolved
youngjeong46
youngjeong46 previously approved these changes Jul 16, 2023
Copy link
Collaborator

@youngjeong46 youngjeong46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - approved through tech validation using patterns.

@youngjeong46
Copy link
Collaborator

@ronahk There is a merge conflict for the docs file. Can you fix it, then we can merge.

@ronahk ronahk closed this Jul 17, 2023
@ronahk ronahk force-pushed the main branch 2 times, most recently from 7585a95 to 4b1c85f Compare July 17, 2023 08:17
@ronahk
Copy link
Contributor Author

ronahk commented Jul 17, 2023

@ronahk There is a merge conflict for the docs file. Can you fix it, then we can merge.

Fixed, thanks!

@ronahk ronahk requested a review from youngjeong46 July 17, 2023 08:31
Copy link
Collaborator

@youngjeong46 youngjeong46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@shapirov103 shapirov103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shapirov103 shapirov103 merged commit 3e24524 into aws-quickstart:main Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants