Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upbound Universal Crossplane Addon for EKS Managed Addon #612

Merged
merged 7 commits into from
Mar 15, 2023
Merged

Upbound Universal Crossplane Addon for EKS Managed Addon #612

merged 7 commits into from
Mar 15, 2023

Conversation

elamaran11
Copy link
Collaborator

Issue #, if available:

Description of changes:

With respect to the Issue #318 ro build an addon for CrossPlane, this PR addresses the creation for Upbound Universal Crossplane addon using EKS Managed addon.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

shapirov103
shapirov103 reviewed Mar 9, 2023
View reviewed changes
Copy link
Collaborator

@shapirov103 shapirov103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, a couple of minor comments.

docs/addons/upbound-universal-crossplane.md Outdated
# Command to show versions of the UXP add-on
aws eks describe-addon-versions
--addon-name upbound_universal-crossplane \
--kubernetes-version 1.23 \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are on 1.24 now.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

examples/blueprint-construct/index.ts Outdated
@@ -23,7 +23,7 @@ export interface BlueprintConstructProps {
export default class BlueprintConstruct {
constructor(scope: Construct, props: cdk.StackProps) {

blueprints.HelmAddOn.validateHelmVersions = true;
blueprints.HelmAddOn.validateHelmVersions = false;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was it intentional?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it is not. Used it for my testing. Reverted back

@elamaran11
Copy link
Collaborator Author

@shapirov103 All comments are fixed. Please run e2e.

shapirov103
shapirov103 previously approved these changes Mar 10, 2023
View reviewed changes
Copy link
Collaborator

@shapirov103 shapirov103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shapirov103
Copy link
Collaborator

/do-e2e-tests

aws-ia-ci
aws-ia-ci requested changes Mar 10, 2023
View reviewed changes
Copy link

@aws-ia-ci aws-ia-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end to end tests failed. A maintainer can provide more details.

@shapirov103
Copy link
Collaborator

@elamaran11 getting this error:

blueprint-construct-dev \| 86/216 \| 6:01:33 AM \| CREATE_FAILED \| AWS::EKS::Addon \| upbound_universal-crossplane-addOn (upbounduniversalcrossplaneaddOn) Resource handler returned message: "Addon specified is not supported (Service: Eks, Status Code: 400, Request ID: 9c48bd59-013d-45cc-9f91-22363634444e)" (RequestToken: 1050d10c-13b8-84f5-1257-b0ab55c385f5, HandlerErrorCode: InvalidRequest)

@shapirov103
Copy link
Collaborator

/do-e2e-tests

aws-ia-ci
aws-ia-ci requested changes Mar 10, 2023
View reviewed changes
Copy link

@aws-ia-ci aws-ia-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end to end tests failed. A maintainer can provide more details.

@shapirov103
Copy link
Collaborator

Failed, presumably due to missing subscription to the Upbound add-on. Added subscription.

@shapirov103
Copy link
Collaborator

/do-e2e-tests

aws-ia-ci
aws-ia-ci requested changes Mar 10, 2023
View reviewed changes
Copy link

@aws-ia-ci aws-ia-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end to end tests failed. A maintainer can provide more details.

@shapirov103
Copy link
Collaborator

@elamaran11 please merge from main, there is a conflict now.

@elamaran11
Copy link
Collaborator Author

@elamaran11 please merge from main, there is a conflict now.

@shapirov103 I have fixed the merge conflict now. Please proceed with e2e after the subscription is active for 1.24

@elamaran11
Copy link
Collaborator Author

Also LT Changes are removed. Please proceed with e2e

@shapirov103
Copy link
Collaborator

/do-e2e-tests

aws-ia-ci
aws-ia-ci approved these changes Mar 15, 2023
View reviewed changes
Copy link

@aws-ia-ci aws-ia-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end to end tests passed

@shapirov103 shapirov103 merged commit bc76548 into main Mar 15, 2023
@shapirov103 shapirov103 deleted the feature/crossPlaneAddon branch March 15, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shapirov103 shapirov103 shapirov103 approved these changes

@aws-ia-ci aws-ia-ci aws-ia-ci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elamaran11 @shapirov103 @aws-ia-ci