docs: adding documentation for paralus addon #714
Conversation
Signed-off-by: Nirav Parikh <[email protected]>
niravparikh05
requested review from
aws-ia-ci,
a team,
parkand1,
shapirov103,
youngjeong46 and
elamaran11
as code owners
There was a problem hiding this comment.
@niravparikh05 @parkand1
If you read this doc, it is very confusing what pattern we are talking about, since the pattern is in another repo. My suggestion is this:
- Change this PR and only provide a general description of the add-on and a link to the patterns repo with the paralus pattern implementation.
- Move all pattern specific narrative away from this PR to a separate PR in the patterns repo.
Link both PRs.
Please use existing OSS and commercial add-ons for reference. For example OSS add-on pixie.
Or DataDog addon.
Just FYI, I am open to add a reference to Rafay in this PR to make it worthwhile their efforts. A small blurb on Rafay with a link to more advanced features for example, will be acceptable.
Signed-off-by: nirparikh05 <[email protected]>
|
@shapirov103 @parkand1 I have restructed the document addressing your comments and feedback, do have a look and let me know if any further changes are required. |
Signed-off-by: nirparikh05 <[email protected]>
…-blueprints into paralus-addon-docs
There was a problem hiding this comment.
@shapirov103 have addressed your comments, please have a look
There was a problem hiding this comment.
LGTM
@parkand1 there are some minor editorial changes that we will need to apply, such as rbac = RBAC, punctuation in some places
Issue #, if available:
Description of changes:
Adding documentation for paralus addon which got merged as part of aws-samples/cdk-eks-blueprints-patterns#67
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.