Karpenter Addon: adding AMI Selector, refactor to use NodeTemplate #736
Conversation
youngjeong46
requested review from
aws-ia-ci,
a team,
parkand1,
shapirov103 and
elamaran11
as code owners
|
@shapirov103 FYI |
|
/do-e2e-tests |
lib/addons/karpenter/index.ts
Outdated
| /** | ||
| * Taints for the provisioned nodes - Taints may prevent pods from scheduling if they are not tolerated by the pod. | ||
| */ | ||
| taints?: { |
There was a problem hiding this comment.
Why not use this type https://docs.aws.amazon.com/cdk/api/v1/docs/@aws-cdk_aws-eks.TaintSpec.html?
There was a problem hiding this comment.
This didn't work - the provisioner CRD doesn't recognize TaintEffect interface and will cause an error.
There was a problem hiding this comment.
I proposed to only change the API layer for convenience. The backend will remain the same, you will need to convert TaintEffect to string. However, this functionality is already released, so my only comment here is: let's extracts the TaintType, put it in the spi types and reuse in the current form.
lib/addons/karpenter/index.ts
Outdated
| /** | ||
| * Labels applied to all nodes | ||
| */ | ||
| labels?: { |
There was a problem hiding this comment.
We have type Values for this and annotations.
|
/do-e2e-tests |
youngjeong46
dismissed stale reviews from aws-ia-ci, parkand1, and elamaran11
via
8847e02
lib/addons/karpenter/index.ts
Outdated
| /** | ||
| * Taints for the provisioned nodes - Taints may prevent pods from scheduling if they are not tolerated by the pod. | ||
| */ | ||
| taints?: { |
There was a problem hiding this comment.
I proposed to only change the API layer for convenience. The backend will remain the same, you will need to convert TaintEffect to string. However, this functionality is already released, so my only comment here is: let's extracts the TaintType, put it in the spi types and reuse in the current form.
addressed! |
Issue #, if available: #726
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.