Fixing Launch Template Issue #768 #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elamaran11
requested review from
aws-ia-ci,
a team,
parkand1,
shapirov103 and
youngjeong46
as code owners
shapirov103
reviewed
Jul 11, 2023
| const ebsDeviceProps: ec2.EbsDeviceProps = { | ||
| deleteOnTermination: false, | ||
| volumeType: ec2.EbsDeviceVolumeType.GP2 | ||
| }; | ||
|
|
||
| return { |
There was a problem hiding this comment.
What prompted these changes? Are they intentional?
There was a problem hiding this comment.
WIndows pattern prompted these changes. So we can use Disksize which takes care of EBS volume so we dont need to use LT.
|
/do-e2e-tests |
aws-ia-ci
requested changes
Jul 11, 2023
|
@shapirov103 On checking the quick start account, this look like a VPC delete failure issue. Do you want to cleanup and rerun or we are good to merge? |
|
/do-e2e-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.