Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding create Namespace support for Metrics-Server addon #773

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Adding create Namespace support for Metrics-Server addon #773

merged 3 commits into from
Jul 18, 2023

Conversation

tsahiduek
Copy link
Contributor

@tsahiduek tsahiduek commented Jul 13, 2023 •
edited
Loading

Issue #, if available:
#772
Description of changes:
Add createNamespace support for Metrics Server addon

Tests run successfully

Test Suites: 13 passed, 13 total
Tests:       59 passed, 59 total
Snapshots:   0 total
Time:        22.749 s
Ran all test suites.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

elamaran11
elamaran11 requested changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tsahiduek Nice PR. Please make these changes also doc updates are missing.

lib/addons/metrics-server/index.ts Outdated Show resolved Hide resolved
lib/addons/metrics-server/index.ts Outdated Show resolved Hide resolved
shapirov103
shapirov103 reviewed Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@shapirov103 shapirov103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tsahiduek looks great and thank for you for addressing it. I have a relatively minor feedback, will merge after it.

lib/addons/metrics-server/index.ts Show resolved Hide resolved
@tsahiduek
Add new value to docs
e7cf5f6 
Removed duplicate lines from `kube-state-metrics` like in `metrics-server` addon
@tsahiduek
Copy link
Contributor Author

@tsahiduek Nice PR. Please make these changes also doc updates are missing.

Done

shapirov103
shapirov103 approved these changes Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@shapirov103 shapirov103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shapirov103
Copy link
Collaborator

/do-e2e-tests

aws-ia-ci
aws-ia-ci approved these changes Jul 18, 2023
View reviewed changes
Copy link

@aws-ia-ci aws-ia-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end to end tests passed

elamaran11
elamaran11 approved these changes Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too!

@elamaran11 elamaran11 merged commit 0928491 into aws-quickstart:main Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shapirov103 shapirov103 shapirov103 approved these changes

@elamaran11 elamaran11 elamaran11 approved these changes

@aws-ia-ci aws-ia-ci aws-ia-ci approved these changes

@parkand1 parkand1 Awaiting requested review from parkand1

@youngjeong46 youngjeong46 Awaiting requested review from youngjeong46 youngjeong46 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tsahiduek @shapirov103 @aws-ia-ci @elamaran11