Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct API to get signaling retry count to publish to cloud watch #217

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kateyanurag
Copy link

Issue #, if available:

Description of changes:
Use correct API to get signaling retry count to publish to cloud watch

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@disa6302 disa6302 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the retry count would not change if the signaling client creation fails in a loop and the application exits. This was the whole point of using the read only value because that way we would have the value throughout the life of the signaling client object.

Why are we making this change? Because the readOnly value is updated everytime we complete a call to the createSignalingClient/fetch(if I recall correctly) anyways.

If the create/fetch call fails after max retries, the signalingClientMetrics object would be Null and we would never get the metric out. (Basically, we would fail with STATUS_NULL_ARG in this function).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants