Merge pull request #254 from aws-samples/fix/job-status-duplicate

Fix/job status duplicate

CHANGELOG.md

@@ -6,6 +6,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Added
+- Fix an issue with job status indicator (step function workflow) inserting duplicate entries into DynamoDB.
+
 ## [0.7.7] - 2024-03-06
 ### Added
 - Fix #245 TranscriptKendraSearch page fails to build / load after deployment

VERSION

@@ -1 +1 @@
-0.7.7
+0.7.7

pca-ui/cfn/lib/deploy.template

@@ -94,7 +94,7 @@ Resources:
     Properties:
       ServiceToken: !GetAtt DeployFunction.Arn
       Counter: !Ref DeployCountValue
-      Version: "0.7.6"
+      Version: "0.7.8"
 
   Configure:
     Type: "AWS::CloudFormation::CustomResource"

pca-ui/src/lambda/index.js

@@ -83,6 +83,7 @@ async function createRecord(record) {
         agent: parsed.ConversationAnalytics.Agent,
         customer: parsed.ConversationAnalytics.Cust,
         guid: parsed.ConversationAnalytics.GUID,
+        status: "Done",
     };
 
 

pca-ui/src/lambda/input_bucket_trigger.js

@@ -116,9 +116,18 @@ exports.handler = async function (event, context) {
         console.log(input);
         const jobName = getJobNameFromKey(input.key);
         const outputFileName = getFilenameFromKey(input.key);
-        const promise = createRecord(outputFileName, jobName, outputState);
-        return await Promise.all([promise]);
-
+
+        // The Done/Success state corresponds to when pca-aws-sf-post-processing function
+        // completes successfully. It writes the final results to the output (results) S3 bucket.
+        // The S3 bucket has a trigger that finally updates the DynamoDB table with call summary
+        // and other information. This creates a race condition and can cause a "stale" Done record
+        // to be written to the DynamoDB table. Handle updating the status to Done in the output
+        // S3 bucket trigger.
+
+        if (outputState !== "Done") {
+            const promise = createRecord(outputFileName, jobName, outputState);
+            return await Promise.all([promise]);
+        }
     } else if(eventType === "Object Created") {
         // this is most likely the s3 end drop trigger
         const eventObjectKey = event.detail.object.key;

pca-ui/src/www/src/components/ContactTable.js

@@ -23,7 +23,7 @@ const COLUMN_DEFINITIONS = [
     header: "Timestamp",
     sortingField: "timestamp",
     cell: (d) => {
-      if(d.status !== undefined && d.status.length > 0) {
+      if(d.status !== undefined && d.status.length > 0 && d.status !== "Done") {
         return (
             Formatter.Timestamp(d.timestamp)
         )
@@ -40,7 +40,7 @@ const COLUMN_DEFINITIONS = [
     id: "jobName",
     header: "Job Name",
     cell: (d) => {
-      if(d.status !== undefined && d.status.length > 0) {
+      if(d.status !== undefined && d.status.length > 0 && d.status !== "Done") {
         return (
             d.jobName
         )