Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix s3 issue if deploying from region other than us-east-1 #603

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arief-hidayat
Copy link

Issue #, if available:
encounter S3 issue when deploying from ap-southeast-3 (other than us-east-1), such as CORS.

Description of changes:
follow recommendation from https://aws.amazon.com/blogs/media/deep-dive-into-cors-configs-on-aws-s3-how-to/

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@charles-marion
Copy link
Collaborator

charles-marion commented Nov 12, 2024

Hi @arief-hidayat ,

Thank you for the update! (and sorry for the late follow up)
Can you clarify what is the issue in other regions (or error you got)?

The use of s3v4 was already set for all pre-signed URLs (which is when CORS would matter). (And the SDK automatically sets the current region)

That being said I don't see a downside of this change since v4 is the current version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants