Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/model name validation #611

Closed
wants to merge 3 commits into from

Conversation

gbone24
Copy link

@gbone24 gbone24 commented Nov 30, 2024

Issue #, if available:

Description of changes:
constants used during validation do not include a colon :. This breaks validating titan v2 embedding models that actually have a colon in their name: "amazon.titan-embed-text-v2:0"
image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@charles-marion
Copy link
Collaborator

Thank you for the change. Adding support for Titan v2 is a great addition.

There are style issues (npm run vet-all)

If you have time please have a look otherwise I can do it at a later time.

@gbone24 gbone24 closed this by deleting the head repository Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants