Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add enableArgocdFinalizers options #73

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions chart/templates/agones.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ kind: Application
metadata:
name: agones
namespace: argocd
{{ if .Values.enableArgocdFinalizers }}
finalizers:
- resources-finalizer.argocd.argoproj.io
{{ end }}
spec:
project: default
source:
Expand Down
2 changes: 2 additions & 0 deletions chart/templates/appmesh-controller.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ kind: Application
metadata:
name: appmesh-controller
namespace: argocd
{{ if .Values.enableArgocdFinalizers }}
finalizers:
- resources-finalizer.argocd.argoproj.io
{{ end }}
spec:
project: default
source:
Expand Down
2 changes: 2 additions & 0 deletions chart/templates/argo-rollouts.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ kind: Application
metadata:
name: argo-rollouts
namespace: argocd
{{ if .Values.enableArgocdFinalizers }}
finalizers:
- resources-finalizer.argocd.argoproj.io
{{ end }}
spec:
project: default
source:
Expand Down
2 changes: 2 additions & 0 deletions chart/templates/aws-calico.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ kind: Application
metadata:
name: aws-calico
namespace: argocd
{{ if .Values.enableArgocdFinalizers }}
finalizers:
- resources-finalizer.argocd.argoproj.io
{{ end }}
spec:
project: default
source:
Expand Down
2 changes: 2 additions & 0 deletions chart/templates/aws-cloudwatch-metrics.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ kind: Application
metadata:
name: aws-cloudwatch-metrics
namespace: argocd
{{ if .Values.enableArgocdFinalizers }}
finalizers:
- resources-finalizer.argocd.argoproj.io
{{ end }}
spec:
project: default
source:
Expand Down
2 changes: 2 additions & 0 deletions chart/templates/aws-efs-csi-driver.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ kind: Application
metadata:
name: aws-efs-csi-driver
namespace: argocd
{{ if .Values.enableArgocdFinalizers }}
finalizers:
- resources-finalizer.argocd.argoproj.io
{{ end }}
spec:
project: default
source:
Expand Down
2 changes: 2 additions & 0 deletions chart/templates/aws-for-fluent-bit.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ kind: Application
metadata:
name: aws-for-fluent-bit
namespace: argocd
{{ if .Values.enableArgocdFinalizers }}
finalizers:
- resources-finalizer.argocd.argoproj.io
{{ end }}
spec:
project: default
source:
Expand Down
2 changes: 2 additions & 0 deletions chart/templates/aws-load-balancer-controller.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ kind: Application
metadata:
name: aws-load-balancer-controller
namespace: argocd
{{ if .Values.enableArgocdFinalizers }}
finalizers:
- resources-finalizer.argocd.argoproj.io
{{ end }}
spec:
project: default
source:
Expand Down
2 changes: 2 additions & 0 deletions chart/templates/aws-otel-collector.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ kind: Application
metadata:
name: aws-otel-collector
namespace: argocd
{{ if .Values.enableArgocdFinalizers }}
finalizers:
- resources-finalizer.argocd.argoproj.io
{{ end }}
spec:
project: default
source:
Expand Down
2 changes: 2 additions & 0 deletions chart/templates/cert-manager.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ kind: Application
metadata:
name: cert-manager
namespace: argocd
{{ if .Values.enableArgocdFinalizers }}
finalizers:
- resources-finalizer.argocd.argoproj.io
{{ end }}
spec:
project: default
source:
Expand Down
2 changes: 2 additions & 0 deletions chart/templates/chaos-mesh.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ kind: Application
metadata:
name: chaos-mesh
namespace: argocd
{{ if .Values.enableArgocdFinalizers }}
finalizers:
- resources-finalizer.argocd.argoproj.io
{{ end }}
spec:
project: default
source:
Expand Down
2 changes: 2 additions & 0 deletions chart/templates/cluster-autoscaler.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ kind: Application
metadata:
name: cluster-autoscaler
namespace: argocd
{{ if .Values.enableArgocdFinalizers }}
finalizers:
- resources-finalizer.argocd.argoproj.io
{{ end }}
spec:
project: default
source:
Expand Down
2 changes: 2 additions & 0 deletions chart/templates/external-dns.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ kind: Application
metadata:
name: external-dns
namespace: argocd
{{ if .Values.enableArgocdFinalizers }}
finalizers:
- resources-finalizer.argocd.argoproj.io
{{ end }}
spec:
project: default
source:
Expand Down
2 changes: 2 additions & 0 deletions chart/templates/external-secrets.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ kind: Application
metadata:
name: external-secrets
namespace: argocd
{{ if .Values.enableArgocdFinalizers }}
finalizers:
- resources-finalizer.argocd.argoproj.io
{{ end }}
spec:
project: default
source:
Expand Down
2 changes: 2 additions & 0 deletions chart/templates/gatekeeper.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ kind: Application
metadata:
name: gatekeeper
namespace: argocd
{{ if .Values.enableArgocdFinalizers }}
finalizers:
- resources-finalizer.argocd.argoproj.io
{{ end }}
spec:
project: default
source:
Expand Down
2 changes: 2 additions & 0 deletions chart/templates/ingress-nginx.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ kind: Application
metadata:
name: ingress-nginx
namespace: argocd
{{ if .Values.enableArgocdFinalizers }}
finalizers:
- resources-finalizer.argocd.argoproj.io
{{ end }}
spec:
project: default
source:
Expand Down
2 changes: 2 additions & 0 deletions chart/templates/keda.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ kind: Application
metadata:
name: keda
namespace: argocd
{{ if .Values.enableArgocdFinalizers }}
finalizers:
- resources-finalizer.argocd.argoproj.io
{{ end }}
spec:
project: default
source:
Expand Down
2 changes: 2 additions & 0 deletions chart/templates/kube-state-metrics.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ kind: Application
metadata:
name: kube-state-metrics
namespace: argocd
{{ if .Values.enableArgocdFinalizers }}
finalizers:
- resources-finalizer.argocd.argoproj.io
{{ end }}
spec:
project: default
source:
Expand Down
2 changes: 2 additions & 0 deletions chart/templates/kubecost.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ kind: Application
metadata:
name: kubecost
namespace: argocd
{{ if .Values.enableArgocdFinalizers }}
finalizers:
- resources-finalizer.argocd.argoproj.io
{{ end }}
spec:
project: default
source:
Expand Down
2 changes: 2 additions & 0 deletions chart/templates/kubernetes-dashboard.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ kind: Application
metadata:
name: kubernetes-dashboard
namespace: argocd
{{ if .Values.enableArgocdFinalizers }}
finalizers:
- resources-finalizer.argocd.argoproj.io
{{ end }}
spec:
project: default
source:
Expand Down
2 changes: 2 additions & 0 deletions chart/templates/metrics-server.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ kind: Application
metadata:
name: metrics-server
namespace: argocd
{{ if .Values.enableArgocdFinalizers }}
finalizers:
- resources-finalizer.argocd.argoproj.io
{{ end }}
spec:
project: default
source:
Expand Down
2 changes: 2 additions & 0 deletions chart/templates/prometheus.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ kind: Application
metadata:
name: prometheus
namespace: argocd
{{ if .Values.enableArgocdFinalizers }}
finalizers:
- resources-finalizer.argocd.argoproj.io
{{ end }}
spec:
project: default
source:
Expand Down
2 changes: 2 additions & 0 deletions chart/templates/promtail.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ kind: Application
metadata:
name: promtail
namespace: argocd
{{ if .Values.enableArgocdFinalizers }}
finalizers:
- resources-finalizer.argocd.argoproj.io
{{ end }}
spec:
project: default
source:
Expand Down
2 changes: 2 additions & 0 deletions chart/templates/smb-sci-driver.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ kind: Application
metadata:
name: smb-csi-driver
namespace: argocd
{{ if .Values.enableArgocdFinalizers }}
finalizers:
- resources-finalizer.argocd.argoproj.io
{{ end }}
spec:
project: default
source:
Expand Down
2 changes: 2 additions & 0 deletions chart/templates/spark-operator.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ kind: Application
metadata:
name: spark-operator
namespace: argocd
{{ if .Values.enableArgocdFinalizers }}
finalizers:
- resources-finalizer.argocd.argoproj.io
{{ end }}
spec:
project: default
source:
Expand Down
2 changes: 2 additions & 0 deletions chart/templates/tetrate-istio.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ kind: Application
metadata:
name: tetrate-istio
namespace: argocd
{{ if .Values.enableArgocdFinalizers }}
finalizers:
- resources-finalizer.argocd.argoproj.io
{{ end }}
spec:
project: default
source:
Expand Down
2 changes: 2 additions & 0 deletions chart/templates/traefik.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ kind: Application
metadata:
name: traefik
namespace: argocd
{{ if .Values.enableArgocdFinalizers }}
finalizers:
- resources-finalizer.argocd.argoproj.io
{{ end }}
spec:
project: default
source:
Expand Down
2 changes: 2 additions & 0 deletions chart/templates/vpa.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ kind: Application
metadata:
name: vpa
namespace: argocd
{{ if .Values.enableArgocdFinalizers }}
finalizers:
- resources-finalizer.argocd.argoproj.io
{{ end }}
spec:
project: default
source:
Expand Down
2 changes: 2 additions & 0 deletions chart/templates/yunikorn.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ kind: Application
metadata:
name: yunikorn
namespace: argocd
{{ if .Values.enableArgocdFinalizers }}
finalizers:
- resources-finalizer.argocd.argoproj.io
{{ end }}
spec:
project: default
source:
Expand Down
4 changes: 3 additions & 1 deletion chart/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ region: ""
account: ""
clusterName: ""

enableArgocdFinalizers: true

# Agones Values
agones:
enable: false
Expand Down Expand Up @@ -166,7 +168,7 @@ kubecost:
# SMB CSI Driver Values
smbCsiDriver:
enable: false

# Chaos Mesh Values
chaosMesh:
enable: false