Simplified Lambda functions

aws-samples · Feb 21, 2018 · bf14046 · bf14046
1 parent c09b29c
commit bf14046
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 10 deletions.
diff --git a/services/kinesis-consumer/src/main/java/com/amazon/KinesisConsumerHandler.java b/services/kinesis-consumer/src/main/java/com/amazon/KinesisConsumerHandler.java
@@ -31,11 +31,11 @@
 
 import java.nio.ByteBuffer;
 
-public class KinesisConsumerHandler implements RequestHandler<KinesisEvent, Void> {
+public class KinesisConsumerHandler {
 
     private DynamoDB dynamoDB;
 
-    public Void handleRequest(KinesisEvent kinesisEvent, Context context) {
+    public void handleRequest(KinesisEvent kinesisEvent, Context context) {
 
         LambdaLogger logger = context.getLogger();
 
@@ -81,7 +81,7 @@ public Void handleRequest(KinesisEvent kinesisEvent, Context context) {
             }
         }
 
-        return null;
+        return;
     }
 
     private AmazonDynamoDB createDynamodbClient(final Region region) {

diff --git a/services/redis-updater/src/main/java/com/amazon/RedisUpdaterHandler.java b/services/redis-updater/src/main/java/com/amazon/RedisUpdaterHandler.java
@@ -30,14 +30,13 @@
 import static com.amazon.util.Constants.REDIS_HOST;
 import static com.amazon.util.Constants.REDIS_PORT;
 
-public class RedisUpdaterHandler implements RequestHandler<KinesisEvent, Void> {
+public class RedisUpdaterHandler  {
 
     private Jedis jedis;
     private Charset charset = Charset.forName("UTF-8");
     private ObjectMapper mapper = new ObjectMapper();
 
-    @Override
-    public Void handleRequest(KinesisEvent kinesisEvent, Context context) {
+    public void handleRequest(KinesisEvent kinesisEvent, Context context) {
 
         RedisUpdater redisUpdater = new RedisUpdater();
         LambdaLogger logger = context.getLogger();
@@ -50,7 +49,7 @@ public Void handleRequest(KinesisEvent kinesisEvent, Context context) {
 
                 if (System.getenv(REDIS_HOST) == null) {
                     logger.log("Not Redis host specified");
-                    return null;
+                    return;
                 }
                 String redisHost = System.getenv(REDIS_HOST);
                 int redisPort = System.getenv(REDIS_PORT) == null ? 6379 : Integer.parseInt(System.getenv(REDIS_PORT));
@@ -77,7 +76,7 @@ public Void handleRequest(KinesisEvent kinesisEvent, Context context) {
             }
         }
 
-        return null;
+        return;
     }
 
 

diff --git a/services/redis-updater/src/test/java/com/amazon/RedisUpdaterTest.java b/services/redis-updater/src/test/java/com/amazon/RedisUpdaterTest.java
@@ -143,6 +143,4 @@ public void writeToRedisTest() {
             exc.printStackTrace();
         }
     }
-
-
 }