-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New serverless pattern - lambda cloudwatch metrics and dashboard in cdk - dotnet #1264
Conversation
@srcsakthivel there are some issues with this pattern. please fix them and then i can proceed with the review. |
Thanks for the review and valuable feedback. I have made the updates and ready for your review. |
Im following the instructions and when running cdk deploy I get this error
|
Took sometime to reproduce the issue. I have added in the requirement section and troubleshooting step. |
This is still failing when following the instructions.
|
I have explicitly called out the OS Version in requirement. Please let me know if that looks good. Also, next if you ran into similar issue, please share the docker info as well. Thanks. |
Does this only works on a Architecture: x86_64? That might be the reason why it fails in my side. If that is the case, can you make this PR more generic? |
I guess it is because of the Package - AWSLogsLambdaInsights, $ rpm -qi AWSLogsLambdaInsights-1.0-1 Other details: awsdocs/amazon-cloudwatch-user-guide#97 |
@mavi888 - just following up to see if you have any updates. |
Due to PTO, we will pick this up for review in about 2 weeks. Sorry for the delay. |
The layer is also available for ARN: https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/Lambda-Insights-Getting-Started-docker.html#Lambda-Insights-Getting-Started-docker-ARM64 Can you make it more generic? So everybody can deploy it? |
@mavi888 - I have updated the code with variables. Updated the Readme.md as well for the ARM. |
Do you also need to add instructions to the readme on how to work with these variables? |
I have added those. |
This submission is too complex for patterns. Once the code is working, I would recommend resubmitting to the Serverless Land Repos collection: https://serverlessland.com/repos. |
Description of changes:
This pattern helps build CloudWatch Dashboard with AWS Lambda Metrics. The Dashboard built with 4 widgets,
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.