Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Serverless pattern: websocket api to SNS with request validation #1409

Merged
merged 5 commits into from
Jun 27, 2023

Conversation

bharat-aws
Copy link

New Serverless pattern: websocket api to SNS with request validation

Issue #, if available:

Description of changes:
new pattern to integrate websocket API with SNS with request validation

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions
Copy link

@bharat-aws looks like you are missing the example-pattern.json file in your pattern.

You can find the example-pattern template here.

The file is used on ServerlessLand and is required. Once the file is added we can review the pattern.

@boyney123
Copy link
Contributor

Hi @bharat-aws

There is no files in your PR? Maybe missing something here?

@bharat-aws
Copy link
Author

bharat-aws commented Jun 19, 2023

hi, apologies for the confusion. i merged my work branch with my main branch, you should see the changes now

@github-actions
Copy link

@bharat-aws your 'example-pattern.json' is missing some key fields, please review below and address any errors you have

  1. instance: instance requires property "language"

If you need any help, take a look at the example-pattern file.

Make the changes, and push your changes back to this pull request. When all automated checks are successful, the Serverless DA team will process your pull request.

@boyney123
Copy link
Contributor

No need for language value.

@bharat-aws
Copy link
Author

is there any ETA on when this PR will be evaluated?

@boyney123
Copy link
Contributor

Thanks @bharat-aws , just checked will merge this in

@boyney123 boyney123 merged commit 0eb91dd into aws-samples:main Jun 27, 2023
@bharat-aws
Copy link
Author

i see validate-pattern failed for this merge. also the serverlessLand article is not published as well. can you share how can we resolve it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants