Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New serverless pattern - RDS instance event subscriptions to SNS (Terraform) #1417

Conversation

MakendranG
Copy link
Contributor

@MakendranG MakendranG commented Jun 19, 2023

Issue #1418, if available:

Description of changes:

This terraform template configures an event subscription for failure, low storage, and availability event categories for RDS Instances.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jbesw
Copy link
Contributor

jbesw commented Jun 21, 2023

This submission includes files from another submission. Please resubmit the PR only with the files for this pattern.

@jbesw
Copy link
Contributor

jbesw commented Jun 21, 2023

Also, please verify your example-pattern.json file since this has failed validation.

@MakendranG
Copy link
Contributor Author

MakendranG commented Jun 22, 2023

@jbesw

This submission includes files from another submission. Please resubmit the PR only with the files for this pattern.

There are only three files in it which is a terraform file, a readme and example json file. All three files are required. The another submission is for cloudformation.

@MakendranG
Copy link
Contributor Author

MakendranG commented Jun 22, 2023

@jbesw

Also, please verify your example-pattern.json file since this has failed validation.

I have validated the example json file. It have required parameters. In the schema validation failure, I have checked it but there is no specific error mentioned to fix it. Kindly help what need to be fixed here.

@boyney123
Copy link
Contributor

@jbesw

This submission includes files from another submission. Please resubmit the PR only with the files for this pattern.

There are only three files in it which is a terraform file, a readme and example json file. All three files are required. The another submission is for cloudformation.

From what I can tell there are two patterns here? One for SAM and Terraform.

Could you raise them as separate PR for us to review please? That way our automated systems can pick up your pattern and check your pattern file, and it's easier for us to review going forward. Thanks.

@MakendranG
Copy link
Contributor Author

@jbesw

Thanks for the update.
As per the request, I have removed SAM pattern. This PR will be for terraform. Automated system have picked the pattern and validated. Now it is waiting for approval. Kindly do the needful.

@MakendranG
Copy link
Contributor Author

@jbesw @boyney123 @mavi888

Requested changes have been done.

@julianwood julianwood merged commit 5244e8a into aws-samples:main Jul 10, 2023
2 checks passed
@julianwood julianwood assigned julianwood and unassigned mavi888 and julianwood Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants