Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added example-pattern.json #1468

Conversation

shankey28
Copy link
Contributor

Added example-pattern.json

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@shankey28
Copy link
Contributor Author

@boyney123 Please advise on this PR.

@shankey28
Copy link
Contributor Author

@boyney123 Please review this PR. All the checks are passing now.

@shankey28
Copy link
Contributor Author

@bls20AWS Can you please check here? This has been pending for a while now.

@boyney123
Copy link
Contributor

Thanks @shankey28 for the patience.

They code for the pattern itself is missing? You need to commit then code in this pull request for the pattern, unless I'm missing something here?

@shankey28 shankey28 force-pushed the shankey28-feature-cdk-s3-sqs-lambda-dynamodb branch 2 times, most recently from b8d98e9 to 546a63b Compare August 7, 2023 14:21
@shankey28
Copy link
Contributor Author

@boyney123 Sorry, the code got overwritten in one of the merges. It should be updated now. Please check.

@boyney123
Copy link
Contributor

Still only 2 files changed? Have you pushed the changes?
image

@shankey28
Copy link
Contributor Author

@boyney123 some goofiness going on. Hopefully 3rd time is a charm.

@github-actions
Copy link

@shankey28 looks like you are missing the example-pattern.json file in your pattern.

You can find the example-pattern template here.

The file is used on ServerlessLand and is required. Once the file is added we can review the pattern.

@boyney123
Copy link
Contributor

Thanks! Now your example-pattern file is missing it seems?

@shankey28
Copy link
Contributor Author

Added example-pattern.json file back.

@shankey28
Copy link
Contributor Author

@boyney123 Any update?

@boyney123
Copy link
Contributor

Thank you for your patience @shankey28 , reviewed and merged. Thanks for the PR

@boyney123 boyney123 merged commit ed112b2 into aws-samples:main Aug 25, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants