-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added example-pattern.json #1468
Added example-pattern.json #1468
Conversation
@boyney123 Please advise on this PR. |
@boyney123 Please review this PR. All the checks are passing now. |
@bls20AWS Can you please check here? This has been pending for a while now. |
Thanks @shankey28 for the patience. They code for the pattern itself is missing? You need to commit then code in this pull request for the pattern, unless I'm missing something here? |
b8d98e9
to
546a63b
Compare
@boyney123 Sorry, the code got overwritten in one of the merges. It should be updated now. Please check. |
…//github.com/shankey28/serverless-patterns into shankey28-feature-cdk-s3-sqs-lambda-dynamodb Updated code
@boyney123 some goofiness going on. Hopefully 3rd time is a charm. |
@shankey28 looks like you are missing the example-pattern.json file in your pattern. You can find the example-pattern template here. The file is used on ServerlessLand and is required. Once the file is added we can review the pattern. |
Thanks! Now your example-pattern file is missing it seems? |
Added example-pattern.json file back. |
@boyney123 Any update? |
Thank you for your patience @shankey28 , reviewed and merged. Thanks for the PR |
Added example-pattern.json
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.