Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New pattern submission- s3 lambda dotnet #1472

Merged

Conversation

gtmjohnson
Copy link
Contributor

Issue #1471, New pattern submission s3-lambda-dotnet

Adding new pattern for .NET Lambda - this template uses SAM to deploy a .NET 6 Lambda function, an S3 bucket, and IAM resources required to run the application. The lambda function consumes ObjectCreated events from the S3 bucket and the code takes uploaded images, resizes them into thumbnails, and writes to a new folder in the S3 bucket.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@gtmjohnson gtmjohnson changed the title Grream feature s3 lambda dotnet New pattern submission- s3 lambda dotnet Jul 6, 2023
@github-actions
Copy link

@gtmjohnson your 'example-pattern.json' is missing some key fields, please review below and address any errors you have

  1. language: language is not one of enum values: TypeScript,Node.js,Python,Java,Go,Rust,.NET,OpenAPI,YAML,

If you need any help, take a look at the example-pattern file.

Make the changes, and push your changes back to this pull request. When all automated checks are successful, the Serverless DA team will process your pull request.

@gtmjohnson
Copy link
Contributor Author

@gtmjohnson your 'example-pattern.json' is missing some key fields, please review below and address any errors you have

  1. language: language is not one of enum values: TypeScript,Node.js,Python,Java,Go,Rust,.NET,OpenAPI,YAML,

If you need any help, take a look at the example-pattern file.

Make the changes, and push your changes back to this pull request. When all automated checks are successful, the Serverless DA team will process your pull request.

Changed C# to .NET, which should fix the error

@singledigit
Copy link
Contributor

This is not a good fit for the Serverless Land patterns collection. We have plenty of patterns the demonstrate S3 to a Lambda function. The advantage of this is the code and how to do it in .Net 6. I recommend changing this to either a:

repo: https://serverlessland.com/repos

or

snippret: https://serverlessland.com/snippets

Closing this PR.

@singledigit
Copy link
Contributor

Additionally, if you go forward with the repo, please remove the bucket name parameter. It is not rquired and without it, CloudFromation will create a unique bucket name every time.

@singledigit
Copy link
Contributor

Talked with Garret, there are no AWS SAM and .NET examples. We need to add this pattern.

@singledigit singledigit reopened this Jul 18, 2023
Copy link
Contributor

@singledigit singledigit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove requirement for bucket name and let CFN name the bucket

@singledigit singledigit merged commit 8c08bb1 into aws-samples:main Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants