-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code for Chat-with-slack-channel #1506
Conversation
@TanyaGupta23 looks like you are missing the example-pattern.json file in your pattern. You can find the example-pattern template here. The file is used on ServerlessLand and is required. Once the file is added we can review the pattern. |
I have uploaded the example-pattern.json file |
@TanyaGupta23 your 'example-pattern.json' is missing some key fields, please review below and address any errors you have
If you need any help, take a look at the example-pattern file. Make the changes, and push your changes back to this pull request. When all automated checks are successful, the Serverless DA team will process your pull request. |
Please can you include some more information in the README on how to deploy the pattern and test it. You can link to the external instructions but currently a reader doesn't know how to get started with actually using this pattern. |
Made the changes as suggested. Please check |
Currently this pattern submission is too bare bones. It is just a single resource. Suggest including the SNS topic and IAM role in the template. |
Going to close for now, feel free to re-open once @julianwood comments been addressed, thanks |
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.