Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code for Chat-with-slack-channel #1506

Closed
wants to merge 3 commits into from

Conversation

TanyaGupta23
Copy link

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions
Copy link

@TanyaGupta23 looks like you are missing the example-pattern.json file in your pattern.

You can find the example-pattern template here.

The file is used on ServerlessLand and is required. Once the file is added we can review the pattern.

@TanyaGupta23
Copy link
Author

I have uploaded the example-pattern.json file

@github-actions
Copy link

@TanyaGupta23 your 'example-pattern.json' is missing some key fields, please review below and address any errors you have

  1. framework: framework is not one of enum values: CDK,SAM,Terraform,Serverless Framework,Terraform (with modules),Pulumi

If you need any help, take a look at the example-pattern file.

Make the changes, and push your changes back to this pull request. When all automated checks are successful, the Serverless DA team will process your pull request.

@julianwood
Copy link
Contributor

Please can you include some more information in the README on how to deploy the pattern and test it. You can link to the external instructions but currently a reader doesn't know how to get started with actually using this pattern.
Also, we prefer using AWS SAM for the deployment. Please check whether sam deploy works when deploying this.

@TanyaGupta23
Copy link
Author

Made the changes as suggested. Please check

@julianwood
Copy link
Contributor

Currently this pattern submission is too bare bones. It is just a single resource. Suggest including the SNS topic and IAM role in the template.

@boyney123
Copy link
Contributor

Going to close for now, feel free to re-open once @julianwood comments been addressed, thanks

@boyney123 boyney123 closed this Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants