Changes to serverless pattern #1528
Conversation
|
@mialarconchong looks like you are missing the example-pattern.json file in your pattern. You can find the example-pattern template here. The file is used on ServerlessLand and is required. Once the file is added we can review the pattern. |
|
|
||
| Learn more about this pattern at Serverless Land Patterns:[Create an AWS account](https://serverlessland.com/patterns/cloudtrail-lambda-dynamodb-cdk) | ||
| Learn more about this pattern at Serverless Land Patterns: << Add the live URL here >> |
There was a problem hiding this comment.
update URL with the directory of this pattern
| @@ -29,6 +28,10 @@ s. | |||
| ``` | |||
| npm install | |||
| ``` | |||
| 1. Open the lambda function object_tag_checker.py, and on line 40 replace the example keys with your required keys: | |||
| ``` | |||
| required_keys = {"Key1", "Key2", "Key3", "Key4"} | |||
There was a problem hiding this comment.
what are these for? can you elaborate more or give some examples or links to docs of what you are doing
| ``` | ||
| If the S3 bucket creation was successful, you should receive the following response: | ||
| If the file upload was successful, you should receive the following response: |
There was a problem hiding this comment.
if all of these is related to tags, maybe you need to add this to the testing so we can see how the configured keys related to the tags of the resources
|
|
||
| 1. Navigate to DynamoDB | ||
|
|
||
| 1. Select the table created for this pattern | ||
|
|
||
| 1. Click 'Explore table items' | ||
|
|
||
| 1. Within about 5 minutes or less, you should see a new item populated in the DynamoDB table specifying the ARN of the newly created bucket. The 'is_compliant' column should be set to 'false' since the bucket was created with no tags. |
There was a problem hiding this comment.
Nothing appeared in my table. Please review the instructions.
|
This pattern is not working for me following the testing instructions. Please review the instructions and I will try again |
|
This pattern will be closed next week if there are no updates in this PR. Thanks, |
|
This PR was closed due to innactivity. If closed, reopen it again and fix the comments or submit a new PR with the changes. Thanks, |
Issue #, if available: N/A
Description of changes:
Made changes to how the serverless pattern works, checking s3 object tags
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.