Serverless pattern eventbridge schedule remove one time schedules cdk python #1992
Conversation
|
@undefined looks like you are missing the example-pattern.json file in your pattern. You can find the example-pattern template here. The file is used on ServerlessLand and is required. Once the file is added we can review the pattern. |
There was a problem hiding this comment.
This is missing some of the required files. Can you please check? Also can you expand how is this different from Automatically delete schedules upon completion with Amazon EventBridge Scheduler
|
pattern file and project files updated and included in the merge request . thanks |
|
@undefined your 'example-pattern.json' is missing some key fields, please review below and address any errors you have
If you need any help, take a look at the example-pattern file. Make the changes, and push your changes back to this pull request. When all automated checks are successful, the Serverless DA team will process your pull request. |
| "name": "Manikandan Karimanal", | ||
| "image": "https://drive.google.com/file/d/16r4jGGMpPhu4Igez-lzstIe-L5nJVMxf/view", | ||
| "bio": "Solution Architect @AWS", | ||
| "linkedin": "https://www.linkedin.com/in/manikandanks/" |
There was a problem hiding this comment.
Can you please take a look at the error and fix the LinkedIn Id?
'1. `authors[0].linkedin`: authors[0].linkedin. Please remove the URL in this property, only include the ID to your LinkedIn profile.\n'
There was a problem hiding this comment.
thanks for the input . fixed the example pattern file with LinkedIn id only.
|
Valid pattern file found. Reviewer you can view the pattern file here |
| ``` | ||
| 2. Change directory to the pattern directory: | ||
| ``` | ||
| cd eventbridge-schedule-remove-one-time-schedule-to-sns-cdk-python |
There was a problem hiding this comment.
should this be eventbridge-schedule-remove-one-time-schedules-cdk-python ?
| Along with a schedule and topic, the CDK stack creates an IAM role and policy for Amazon EventBridge Scheduler to assume and send messages. | ||
|
|
||
| ## Testing | ||
| After the stack has been deployed, you can verify Amazon EventBridge is successfully publishing to the topic by viewing the topics "NumberOfMessagesPublished" metric in CloudWatch and verifying positive data points. |
There was a problem hiding this comment.
can you add any screenshot here to make it clear?
|
agreed. updated the folder names as advised. |
|
Valid pattern file found. Reviewer you can view the pattern file here |
|
Valid pattern file found. Reviewer you can view the pattern file here |
Fixed the projectFolder and templateFile
|
Valid pattern file found. Reviewer you can view the pattern file here |
|
@manikandanks2000 I had to fix a couple of small changes in the example-pattern.json file. Please have a look and see if this applies to your other submissions as well. Rest looks good and this PR will be merged in soon. Thanks for your submission. |
|
thanks for your help and the changes made. |
|
@pputhran i see the project merged successfully. but the github project folder name need to be corrected as below. Let me know whether a new merge request is required to make this change. https://serverlessland.com/patterns/eventbridge-schedule-remove-one-time-schedules-cdk-python Incorrect path used : Correct path to be used : |
|
Please open a new PR with the fix. |
Issue #, if available:
Description of changes:
Remove completed Amazon EventBridge Schedules and sent notification using Amazon SNS
This pattern will create an Amazon EventBridge Scheduler and will run every five minutes and will use AWS Lambda to identify expired and completed Amazon Evenbridge Scheduler tasks that are expired 7 days or more and will send an SNS notification once the activity is completed. The pattern is deployed using the AWS Cloud Development Kit (AWS CDK) for Python.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.