Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serverless pattern eventbridge pipe sqs stepfunctions filter transform cdk python #1994

Conversation

manikandanks2000
Copy link
Contributor

Issue #, if available:

Description of changes:
This pattern will use Amazon EventBridge Pipe to accept source messages from Amazon Simple Queue Service and will apply filter and transformation before sending the target message to AWS Step Functions.
This example project implemented with CDK/Python.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pputhran
Copy link
Contributor

pputhran commented Jan 3, 2024

Can you please check the errors and re-submit please?

@manikandanks2000
Copy link
Contributor Author

Fixed the errors on example pattern file and linkedin. Let me know if you have any questions. Thanks

Copy link
Contributor Author

@manikandanks2000 manikandanks2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed the errors and resubmitted for git code review workflow for schema validation check.

Copy link

github-actions bot commented Jan 9, 2024

@undefined your 'example-pattern.json' is missing some key fields, please review below and address any errors you have

  1. gitHub.template.templateURL: gitHub.template.templateURL Please remove the projectFolder value from the templateFile

If you need any help, take a look at the example-pattern file.

Make the changes, and push your changes back to this pull request. When all automated checks are successful, the Serverless DA team will process your pull request.

"templateURL": "serverless-patterns/cdk-sqs-eventbridge-pipes-stepfunctions-filter-transform-python",
"projectFolder": "cdk_eventbridge_pipes_sqs_to_stepfunctions_python",
"templateFile": "cdk_eventbridge_pipes_sqs_to_stepfunctions_python_stack.py"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please take a look at the projectFolder and templateFile references? They seem to be incorrect.

@pputhran
Copy link
Contributor

@manikandanks2000 Did you get a chance to review the requested changes?

@manikandanks2000
Copy link
Contributor Author

@pputhran thanks for the input ..checking the changes, will confirm once complete soon.

@manikandanks2000 manikandanks2000 force-pushed the serverless-pattern-eventbridge-pipe-sqs-stepfunctions-filter-transform-cdk-python branch from a75f056 to 8b402b7 Compare January 13, 2024 16:54
@manikandanks2000
Copy link
Contributor Author

manikandanks2000 commented Jan 13, 2024

@pputhran for some reason this branch picking files outside my changes and was not able to remove them after multiple attempts, hence decided to create new one to avoid issues.
#2043
thanks for your support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants