Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Serverless Patter - FIFO SQS Redrive #2060

Conversation

biswanathmukherjee
Copy link
Collaborator

Issue #, if available:

Description of changes:

The patterns shows the redrive capability of Amazon SQS FIFO queues from dead letter queue. The SAM template deploys two Amazon SQS FIO queues with DLQ, and two AWS Lambda functions to simulate the redrive capability of SQS.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

Valid pattern file found.

Reviewer you can view the pattern file here

Copy link
Contributor

@pputhran pputhran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions and questions.

fifo-sqs-redrive/README.md Outdated Show resolved Hide resolved
fifo-sqs-redrive/README.md Outdated Show resolved Hide resolved
fifo-sqs-redrive/README.md Outdated Show resolved Hide resolved
fifo-sqs-redrive/example-pattern.json Outdated Show resolved Hide resolved
fifo-sqs-redrive/template.yaml Outdated Show resolved Hide resolved
fifo-sqs-redrive/template.yaml Outdated Show resolved Hide resolved
fifo-sqs-redrive/template.yaml Outdated Show resolved Hide resolved
@biswanathmukherjee
Copy link
Collaborator Author

Thanks @pputhran for you review. I have updated the PR based on your review comments. Can you please re-review when you get a minute?

Copy link

Valid pattern file found.

Reviewer you can view the pattern file here

Copy link
Contributor

@pputhran pputhran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Grammar check
@singledigit singledigit merged commit 663d36d into aws-samples:main Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants