Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified the aws sqs send-message command to properly close the value… #2081

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

madhavvishnubhatta
Copy link

… in the json paramter

Issue #, if available:
#2080

Description of changes:
The aws sqs send-message command to test the pattern has an invalid json as value for the message-body parameter. This fixes that by adding a double quote

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

github-actions bot commented Feb 5, 2024

@undefined looks like you are missing the example-pattern.json file in your pattern.

You can find the example-pattern template here.

The file is used on ServerlessLand and is required. Once the file is added we can review the pattern.

@madhavvishnubhatta
Copy link
Author

@undefined looks like you are missing the example-pattern.json file in your pattern.

You can find the example-pattern template here.

The file is used on ServerlessLand and is required. Once the file is added we can review the pattern.

@ellisms Do I need to do anything about the above message? Seems like the message is more relevant for new patterns, not for fixes like these.

@ellisms
Copy link
Contributor

ellisms commented Feb 5, 2024

@undefined looks like you are missing the example-pattern.json file in your pattern.
You can find the example-pattern template here.
The file is used on ServerlessLand and is required. Once the file is added we can review the pattern.

@ellisms Do I need to do anything about the above message? Seems like the message is more relevant for new patterns, not for fixes like these.

No - no action needed on your part. Its not relevant for simple updates.

@benjasl-stripe benjasl-stripe merged commit 47151bd into aws-samples:main Feb 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants