New Serverless Pattern - s3-b2bi-s3- EDI to JSON tranformation #2091
Conversation
s3-b2bi-s3/example-pattern.json
Outdated
| "Delete the Amazon S3 input bucket content: <code>aws s3 rm s3://{EDI214InputBucketName} --recursive</code> --region {my-region}", | ||
| "Delete the Amazon S3 input bucket content: <code>aws s3 rm s3://{EDI214OutputBucketName} --recursive</code> --region {my-region}", |
There was a problem hiding this comment.
please double check the closing code tags. Also, the second line should refer to the output bucket
s3-b2bi-s3/example-pattern.json
Outdated
| "repoURL": "https://github.com/aws-samples/serverless-patterns/tree/main/s3-b2bi-s3", | ||
| "templateURL": "serverless-patterns/s3-b2bi-s3", | ||
| "projectFolder": "s3-b2bi-s3", | ||
| "templateFile": "template.yaml" |
There was a problem hiding this comment.
there is no such file in the folder
There was a problem hiding this comment.
updated.
s3-b2bi-s3/example-pattern.json
Outdated
| "sam deploy -g -t template1.yaml", | ||
| "sam deploy -g -t template2.yaml" |
There was a problem hiding this comment.
Why do you need two templates? Can they have more descriptive names?
There was a problem hiding this comment.
I have updated the names. Please let me know if they are fine now.
s3-b2bi-s3/README.md
Outdated
| - Enter the desired AWS Region. Please refer to the documentation for the list of supported regions. | ||
| - Enter `BusinessName`, `Email`, `Phone`, `EDI214InputBucketName`, `EDI214OutputBucketName`, `MyProfileId` and `MyTransformerId`. Please note the last four parameter values should be given as per the output from the `b2bi-stack1` output. | ||
|
|
||
| Once you have run `sam deploy --guided` mode once and saved arguments to a configuration file (samconfig.toml), you can use `sam deploy` in future to use these defaults. |
There was a problem hiding this comment.
I don't understand how this relevant here. Could you elaborate please?
There was a problem hiding this comment.
Updated. Please let me know if anything else to change.
|
Looks good, thanks for your contribution. A DA will merge your request soon |
Grammar issues
Issue #, if available:
Description of changes:
This sample project demonstrates how AWS B2B Data Interchange can transform EDI Files into JSON as per the transformation logic.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.