-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New pattern submission - Amazon MQ to Amazon EventBridge Message Bus using Amazon EventBridge Pipes #2100
Merged
julianwood
merged 8 commits into
aws-samples:main
from
AdrianBegg:adrianbegg-feature-eventbridge-pipes-amazonmq-to-eventbridge-sam
Apr 17, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrian Begg <[email protected]>
Signed-off-by: Adrian Begg <[email protected]>
…ipes-amazonmq-to-eventbridge-sam
Signed-off-by: Adrian Begg <[email protected]>
…ridge-sam' of https://github.com/AdrianBegg/serverless-patterns into adrianbegg-feature-eventbridge-pipes-amazonmq-to-eventbridge-sam
Ready for review |
pputhran
requested changes
Mar 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few review comments
...pipes-amazonmq-to-eventbridge-sam/eventbridge-pipes-amazonmq-to-eventbridge-sam-pattern.json
Outdated
Show resolved
Hide resolved
...pipes-amazonmq-to-eventbridge-sam/eventbridge-pipes-amazonmq-to-eventbridge-sam-pattern.json
Outdated
Show resolved
Hide resolved
...pipes-amazonmq-to-eventbridge-sam/eventbridge-pipes-amazonmq-to-eventbridge-sam-pattern.json
Outdated
Show resolved
Hide resolved
...pipes-amazonmq-to-eventbridge-sam/eventbridge-pipes-amazonmq-to-eventbridge-sam-pattern.json
Outdated
Show resolved
Hide resolved
...pipes-amazonmq-to-eventbridge-sam/eventbridge-pipes-amazonmq-to-eventbridge-sam-pattern.json
Outdated
Show resolved
Hide resolved
Signed-off-by: Adrian Begg <[email protected]>
Signed-off-by: Adrian Begg <[email protected]>
Thank you for reviewing and for the comments. I have updated with fixes, please let me know if there is any further feedback or changes needed. |
pputhran
approved these changes
Apr 1, 2024
pputhran
added
valid-example-pattern-file
Patterns Guardian approved
and removed
requested-changes
missing-example-pattern-file
labels
Apr 1, 2024
AdrianBegg
deleted the
adrianbegg-feature-eventbridge-pipes-amazonmq-to-eventbridge-sam
branch
April 18, 2024 15:56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2099
Issue #, if available: #2099
Description of changes:
This pattern showcases the use of Amazon EventBridge Pipes to forward events to an Amazon EventBridge custom Message Bus. Using this pattern, events placed on a queue on an Amazon MQ (ActiveMQ) broker are consumed by Amazon EventBridge Pipes which performs a basic transformation and places events on a Amazon EventBridge custom Message Bus. A rule defined on the Amazon EventBridge custom Message Bus writes events received to an Amazon CloudWatch Log Group. This pattern supports an Amazon MQ ActiveMQ broker deployed in a Private VPC (Virtual Private Cloud) or with Public Access enabled however in all cases the Amazon MQ instances must deployed in a subnet with a route to the public Internet.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.