New serverless pattern: s3 trigger fargate task #2379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellisms
requested changes
Aug 5, 2024
There was a problem hiding this comment.
@jeromevdl Thanks for the submission. Requesting a few minor changes.
| @@ -0,0 +1,83 @@ | |||
| # Amazon S3 to AWS Fargate | |||
|
|
|||
| This pattern demonstrates how to trigger an AWS Fargate task when an object is uploaded to Amazon S3. | |||
There was a problem hiding this comment.
Suggested change
| This pattern demonstrates how to trigger an AWS Fargate task when an object is uploaded to Amazon S3. | |
| This pattern demonstrates how to invoke an AWS Fargate task when an object is uploaded to Amazon S3. |
| ``` | ||
| 2. Change directory to the pattern directory: | ||
| ``` | ||
| cd serverless-patterns/s3-teventbridge-fargate-cdk |
There was a problem hiding this comment.
I think this should be s3-eventbridge-fargate-cdk.
| # get log streams | ||
| aws logs describe-log-streams --log-group-name /ecs/doc-ingestion | ||
| # use the latest log stream name in the next command to get logs | ||
| aws logs get-log-events --log-group-name /ecs/doc-ingestion --log-stream-name doc-ingestion-logs/DocIngestion/... |
There was a problem hiding this comment.
Clarify getting the stream name from the previous output.
| aws logs get-log-events --log-group-name /ecs/doc-ingestion --log-stream-name doc-ingestion-logs/DocIngestion/... | ||
| ``` | ||
|
|
||
| 4. You should see the content of your file in the logs. |
There was a problem hiding this comment.
Suggested change
| 4. You should see the content of your file in the logs. | |
| 4. The file contents are displayed in the log. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #2378
Description of changes:
Adding a new pattern: S3 -> EventBridge -> Fargate, using CDK / Typescript
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.