Skip to content

Commit

Permalink
Miscellaneous housekeeping update (#3000)
Browse files Browse the repository at this point in the history
- Remove 404 link in README
- Replace substr with substring
- Add Tel Aviv region to demo
- Replace deprecated set-output for GitHub action
  • Loading branch information
ltrung authored Nov 12, 2024
1 parent 75dc5be commit 34a2aeb
Show file tree
Hide file tree
Showing 12 changed files with 22 additions and 30 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
id: get-version
run: |
current_version=$(.github/script/get-current-version)
echo "::set-output name=version-number::$((${current_version%%.*} - 1))"
echo "version-number=$((${current_version%%.*} - 1))" >> $GITHUB_OUTPUT
browser-compatibility-audio-previous-major-version:
Expand Down
18 changes: 9 additions & 9 deletions .github/workflows/continuous-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
run: |
source ${GITHUB_WORKSPACE}/integration/js/script/need-integ-test
check_if_integ_tests_required
echo ::set-output name=integ_test_required::$requires_integration_test
echo "integ_test_required=$requires_integration_test" >> $GITHUB_OUTPUT
- name: Setup GitHub Actions Host
if: steps.test_needed.outputs.integ_test_required == 'true'
uses: ./.github/actions/setup-integration-test
Expand All @@ -71,7 +71,7 @@
run: |
source ${GITHUB_WORKSPACE}/integration/js/script/need-integ-test
check_if_integ_tests_required
echo ::set-output name=integ_test_required::$requires_integration_test
echo "integ_test_required=$requires_integration_test" >> $GITHUB_OUTPUT
- name: Setup GitHub Actions Host
if: steps.test_needed.outputs.integ_test_required == 'true'
uses: ./.github/actions/setup-integration-test
Expand All @@ -97,7 +97,7 @@
run: |
source ${GITHUB_WORKSPACE}/integration/js/script/need-integ-test
check_if_integ_tests_required
echo ::set-output name=integ_test_required::$requires_integration_test
echo "integ_test_required=$requires_integration_test" >> $GITHUB_OUTPUT
- name: Setup GitHub Actions Host
if: steps.test_needed.outputs.integ_test_required == 'true'
uses: ./.github/actions/setup-integration-test
Expand Down Expand Up @@ -126,7 +126,7 @@
run: |
source ${GITHUB_WORKSPACE}/integration/js/script/need-integ-test
check_if_integ_tests_required
echo ::set-output name=integ_test_required::$requires_integration_test
echo "integ_test_required=$requires_integration_test" >> $GITHUB_OUTPUT
- name: Setup GitHub Actions Host
if: steps.test_needed.outputs.integ_test_required == 'true'
uses: ./.github/actions/setup-integration-test
Expand Down Expand Up @@ -154,7 +154,7 @@
run: |
source ${GITHUB_WORKSPACE}/integration/js/script/need-integ-test
check_if_integ_tests_required
echo ::set-output name=integ_test_required::$requires_integration_test
echo "integ_test_required=$requires_integration_test" >> $GITHUB_OUTPUT
- name: Setup GitHub Actions Host
if: steps.test_needed.outputs.integ_test_required == 'true'
uses: ./.github/actions/setup-integration-test
Expand Down Expand Up @@ -183,7 +183,7 @@
run: |
source ${GITHUB_WORKSPACE}/integration/js/script/need-integ-test
check_if_integ_tests_required
echo ::set-output name=integ_test_required::$requires_integration_test
echo "integ_test_required=$requires_integration_test" >> $GITHUB_OUTPUT
- name: Setup GitHub Actions Host
if: steps.test_needed.outputs.integ_test_required == 'true'
uses: ./.github/actions/setup-integration-test
Expand Down Expand Up @@ -215,7 +215,7 @@
run: |
source ${GITHUB_WORKSPACE}/integration/js/script/need-integ-test
check_if_integ_tests_required
echo ::set-output name=integ_test_required::$requires_integration_test
echo "integ_test_required=$requires_integration_test" >> $GITHUB_OUTPUT
- name: Setup GitHub Actions Host
if: steps.test_needed.outputs.integ_test_required == 'true'
uses: ./.github/actions/setup-integration-test
Expand All @@ -241,7 +241,7 @@
run: |
source ${GITHUB_WORKSPACE}/integration/js/script/need-integ-test
check_if_integ_tests_required
echo ::set-output name=integ_test_required::$requires_integration_test
echo "integ_test_required=$requires_integration_test" >> $GITHUB_OUTPUT
- name: Setup GitHub Actions Host
if: steps.test_needed.outputs.integ_test_required == 'true'
uses: ./.github/actions/setup-integration-test
Expand All @@ -267,7 +267,7 @@
run: |
source ${GITHUB_WORKSPACE}/integration/js/script/need-integ-test
check_if_integ_tests_required
echo ::set-output name=integ_test_required::$requires_integration_test
echo "integ_test_required=$requires_integration_test" >> $GITHUB_OUTPUT
- name: Setup GitHub Actions Host
if: steps.test_needed.outputs.integ_test_required == 'true'
uses: ./.github/actions/setup-integration-test
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/prev-version-integration.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
run: |
prev_version=$(.github/script/get-prev-version)
echo "Previous version:" $prev_version
echo ::set-output name=prev_version::$prev_version
echo "prev_version=$prev_version" >> $GITHUB_OUTPUT
- name: Create a Job ID
id: create-job-id
uses: filipstefansson/uuid-action@ce29ebbb0981ac2448c2e406e848bfaa30ddf04c
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
run: |
npm_publish_tag=$(.github/script/get-npm-tag.js)
echo "Received NPM publish tag:" $npm_publish_tag
echo ::set-output name=npm_tag::$npm_publish_tag
echo "npm_tag=$npm_publish_tag" >> $GITHUB_OUTPUT
- name: Publish to NPM with tag
run: npm publish --tag ${{ steps.npm_tag.outputs.npm_tag }}
env:
Expand Down Expand Up @@ -63,7 +63,7 @@ jobs:
if [[ *$npm_version* = *$current_version* ]]
then
echo "Version is published to npm:" $current_version
echo ::set-output name=npm_version::$current_version
echo "npm_version=$current_version" >> $GITHUB_OUTPUT
break
fi
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-backwards-compatiblity.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
fetch-depth: 0
- name: Version check for backward compatibility check
id: version-check
run: echo "::set-output name=run-check::$(node .github/script/backward-compatibility-run-check.js)"
run: echo "run-check=$(node .github/script/backward-compatibility-run-check.js)" >> $GITHUB_OUTPUT

release-integ-test:
name: Run Backwards Compatible Integration Tests with Release Tarball
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Set starting send bitrate to 1000kbps to reduce time of low resolution at start of connection
- Add per-frame encoding time in video encoding CPU connection health policy
- Replace substr with substring

### Fixed

Expand Down
6 changes: 1 addition & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ The [Amazon Chime SDK Project Board](https://github.com/orgs/aws/projects/12) ca
## Resources

- [Amazon Chime SDK Overview](https://aws.amazon.com/chime/chime-sdk/)
- [Understanding security in Amazon Chime Application and SDK](https://aws.amazon.com/blogs/business-productivity/understanding-security-in-the-amazon-chime-application-and-sdk/)
- [Pricing](https://aws.amazon.com/chime/chime-sdk/pricing/)
- [Supported Browsers](https://docs.aws.amazon.com/chime-sdk/latest/dg/meetings-sdk.html#mtg-browsers)
- [Getting Started Guides](guides/20_Builders_Journey.md)
Expand All @@ -45,11 +46,6 @@ The [Amazon Chime SDK Project Board](https://github.com/orgs/aws/projects/12) ca

In addition to the below, here is a list of [all blog posts about the Amazon Chime SDK](https://aws.amazon.com/blogs/business-productivity/tag/amazon-chime-sdk/).

### High level

- [High Level Architecture — Building a Meeting Application With the Amazon Chime SDK](https://aws.amazon.com/blogs/business-productivity/building-a-meeting-application-using-the-amazon-chime-sdk/)
- [Understanding security in Amazon Chime Application and SDK](https://aws.amazon.com/blogs/business-productivity/understanding-security-in-the-amazon-chime-application-and-sdk/)

### Frontend

- [Transforming Audio and Shared Content](https://aws.amazon.com/blogs/business-productivity/transforming-audio-and-shared-content-in-the-amazon-chime-sdk-for-javascript/)
Expand Down
1 change: 1 addition & 0 deletions demos/browser/app/meetingV2/meetingV2.html
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ <h1 class="h3 mb-3 fw-normal">Join a meeting</h1>
<option value="eu-west-2">United Kingdom (London)</option>
<option value="eu-west-3">France (Paris)</option>
<option value="sa-east-1">Brazil (São Paulo)</option>
<option value="il-central-1">Israel (Tel Aviv)</option>
<option value="us-east-2">United States (Ohio)</option>
<option value="us-west-1">United States (N. California)</option>
<option value="us-west-2">United States (Oregon)</option>
Expand Down
4 changes: 2 additions & 2 deletions demos/browser/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 1 addition & 7 deletions docs/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ <h2>Resources</h2>
</a>
<ul>
<li><a href="https://aws.amazon.com/chime/chime-sdk/">Amazon Chime SDK Overview</a></li>
<li><a href="https://aws.amazon.com/blogs/business-productivity/understanding-security-in-the-amazon-chime-application-and-sdk/">Understanding security in Amazon Chime Application and SDK</a></li>
<li><a href="https://aws.amazon.com/chime/chime-sdk/pricing/">Pricing</a></li>
<li><a href="https://docs.aws.amazon.com/chime-sdk/latest/dg/meetings-sdk.html#mtg-browsers">Supported Browsers</a></li>
<li><a href="guides/20_Builders_Journey.md">Getting Started Guides</a></li>
Expand All @@ -101,13 +102,6 @@ <h2>Resources</h2>
<h2>Blog posts</h2>
</a>
<p>In addition to the below, here is a list of <a href="https://aws.amazon.com/blogs/business-productivity/tag/amazon-chime-sdk/">all blog posts about the Amazon Chime SDK</a>.</p>
<a href="#high-level" id="high-level" style="color: inherit; text-decoration: none;">
<h3>High level</h3>
</a>
<ul>
<li><a href="https://aws.amazon.com/blogs/business-productivity/building-a-meeting-application-using-the-amazon-chime-sdk/">High Level Architecture — Building a Meeting Application With the Amazon Chime SDK</a></li>
<li><a href="https://aws.amazon.com/blogs/business-productivity/understanding-security-in-the-amazon-chime-application-and-sdk/">Understanding security in Amazon Chime Application and SDK</a></li>
</ul>
<a href="#frontend" id="frontend" style="color: inherit; text-decoration: none;">
<h3>Frontend</h3>
</a>
Expand Down
2 changes: 1 addition & 1 deletion src/modality/DefaultModality.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import Modality from './Modality';
export default class DefaultModality implements Modality {
private static MODALITY_SEPARATOR = ContentShareConstants.Modality[0];

static MODALITY_CONTENT = ContentShareConstants.Modality.substr(1);
static MODALITY_CONTENT = ContentShareConstants.Modality.substring(1);

constructor(private _id: string) {}

Expand Down
2 changes: 1 addition & 1 deletion src/versioning/Versioning.ts
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ export default class Versioning {
*/
static get buildSHA(): string {
// Skip the leading 'g'.
return VERSION.hash.substr(1);
return VERSION.hash.substring(1);
}

/**
Expand Down

0 comments on commit 34a2aeb

Please sign in to comment.