Fallback to -1 for browser majorVersion when version is null #2687
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: 1856
Description of changes:
In ReactNative
detect
from detect-browser library returns null for version. When DefaultMessagingSession signs the websocket url, the sigv4 class calls Versioning.sdkUserAgentLowResolution which in turns calls DefaultBrowserBehavior.majorVersion. This should provide a default major version of -1 whenever detect returns null for version.Testing:
Can these tested using a demo application? Please provide reproducible step-by-step instructions.
Unit test + validated could start messaging session in our react native app.
Checklist:
npm run build:release
locally?Yes.
Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?
No.
Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?
No.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.