Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pip mode refactor on Android to put only player into PIP mode vs all activity #156

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: pip mode refactor on Android to put only player into PIP mode vs all activity #156

wants to merge 4 commits into from

Conversation

vnovick
Copy link
Contributor

@vnovick vnovick commented Aug 23, 2023 •
edited
Loading

Description of changes:

  • Refactored setting up pip mode for only the player vs the whole activity on android
  • added buttons in pip mode
  • added broadcast receiver to listen to play, pause actions in pip mode
  • added onPipModeChanged on Android and updated Readme for the usage
  • upgraded RN to 0.72.7
  • solved build issues for iOS
  • initial work on iOS pip mode subscribing support

@Bowlerr
Copy link
Contributor

Bowlerr commented Aug 23, 2023

Awesome !

I was going to look into this android Picture in picture issue.

Is it possible to make the added buttons optional ?

My use case will have no need to them

@vnovick
Copy link
Contributor Author

vnovick commented Aug 23, 2023

Good point. I can add them as optional.

@dawhitla dawhitla mentioned this pull request Aug 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vnovick @Bowlerr