fix: end called when no connection has been established yet (#256)

aws · Oct 22, 2024 · 236e98b · 236e98b
1 parent 22e7cec
commit 236e98b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/mysql/lib/client.ts b/mysql/lib/client.ts
@@ -211,6 +211,12 @@ export class AwsMySQLClient extends AwsClient {
   }
 
   async end() {
+    if (!this.isConnected || !this.targetClient?.client) {
+      // No connections has been initialized.
+      // This might happen if end is called in a finally block when an error occurred while initializing the first connection.
+      return;
+    }
+
     const hostInfo: HostInfo | null = this.pluginService.getCurrentHostInfo();
     const result = await this.pluginManager.execute(
       this.pluginService.getCurrentHostInfo(),

diff --git a/pg/lib/client.ts b/pg/lib/client.ts
@@ -192,6 +192,11 @@ export class AwsPGClient extends AwsClient {
   }
 
   async end() {
+    if (!this.isConnected || !this.targetClient?.client) {
+      // No connections has been initialized.
+      // This might happen if end is called in a finally block when an error occurred while initializing the first connection.
+      return;
+    }
     const hostInfo: HostInfo | null = this.pluginService.getCurrentHostInfo();
     const result = await this.pluginManager.execute(
       hostInfo,