Skip to content

Commit

Permalink
ff
Browse files Browse the repository at this point in the history
  • Loading branch information
comcalvi committed Sep 17, 2024
1 parent e3eaba1 commit 23a4901
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
8 changes: 4 additions & 4 deletions packages/aws-cdk-lib/cx-api/FEATURE_FLAGS.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ Flags come in three types:
| [@aws-cdk/custom-resources:logApiResponseDataPropertyTrueDefault](#aws-cdkcustom-resourceslogapiresponsedatapropertytruedefault) | When enabled, the custom resource used for `AwsCustomResource` will configure the `logApiResponseData` property as true by default | 2.145.0 | (fix) |
| [@aws-cdk/aws-s3:keepNotificationInImportedBucket](#aws-cdkaws-s3keepnotificationinimportedbucket) | When enabled, Adding notifications to a bucket in the current stack will not remove notification from imported stack. | 2.155.0 | (fix) |
| [@aws-cdk/aws-stepfunctions-tasks:useNewS3UriParametersForBedrockInvokeModelTask](#aws-cdkaws-stepfunctions-tasksusenews3uriparametersforbedrockinvokemodeltask) | When enabled, use new props for S3 URI field in task definition of state machine for bedrock invoke model. | 2.156.0 | (fix) |
| [@aws-cdk/core:generateUniqueIdentifiersForTokenizedLists](#aws-cdkcoregenerateuniqueidentifiersfortokenizedlists) | When enabled, generate the Logical ID of the CDKJsonStringify Custom Resource from the Intrinsic's unresovled value. | 2.158.0 | (fix) |
| [@aws-cdk/core:generateTokenAwareStringifyLogicalIdFromTokenValue](#aws-cdkcoregeneratetokenawarestringifylogicalidfromtokenvalue) | When enabled, generate the Logical ID of the CDKJsonStringify Custom Resource from the Intrinsic's unresovled value. | 2.158.0 | (fix) |

<!-- END table -->

Expand Down Expand Up @@ -180,7 +180,7 @@ are migrating a v1 CDK project to v2, explicitly set any of these flags which do
| [@aws-cdk/aws-cloudfront:defaultSecurityPolicyTLSv1.2\_2021](#aws-cdkaws-cloudfrontdefaultsecuritypolicytlsv12_2021) | Enable this feature flag to have cloudfront distributions use the security policy TLSv1.2_2021 by default. | (fix) | 1.117.0 | `false` | `true` |
| [@aws-cdk/pipelines:reduceAssetRoleTrustScope](#aws-cdkpipelinesreduceassetroletrustscope) | Remove the root account principal from PipelineAssetsFileRole trust policy | (default) | | `false` | `true` |
| [@aws-cdk/aws-stepfunctions-tasks:useNewS3UriParametersForBedrockInvokeModelTask](#aws-cdkaws-stepfunctions-tasksusenews3uriparametersforbedrockinvokemodeltask) | When enabled, use new props for S3 URI field in task definition of state machine for bedrock invoke model. | (fix) | | `false` | `true` |
| [@aws-cdk/core:generateUniqueIdentifiersForTokenizedLists](#aws-cdkcoregenerateuniqueidentifiersfortokenizedlists) | When enabled, generate the Logical ID of the CDKJsonStringify Custom Resource from the Intrinsic's unresovled value. | (fix) | | `false` | `true` |
| [@aws-cdk/core:generateTokenAwareStringifyLogicalIdFromTokenValue](#aws-cdkcoregeneratetokenawarestringifylogicalidfromtokenvalue) | When enabled, generate the Logical ID of the CDKJsonStringify Custom Resource from the Intrinsic's unresovled value. | (fix) | | `false` | `true` |

<!-- END diff -->

Expand All @@ -198,7 +198,7 @@ Here is an example of a `cdk.json` file that restores v1 behavior for these flag
"@aws-cdk/aws-cloudfront:defaultSecurityPolicyTLSv1.2_2021": false,
"@aws-cdk/pipelines:reduceAssetRoleTrustScope": false,
"@aws-cdk/aws-stepfunctions-tasks:useNewS3UriParametersForBedrockInvokeModelTask": false,
"@aws-cdk/core:generateUniqueIdentifiersForTokenizedLists": false
"@aws-cdk/core:generateTokenAwareStringifyLogicalIdFromTokenValue": false
}
}
```
Expand Down Expand Up @@ -1381,7 +1381,7 @@ When this feature flag is enabled, specify newly introduced props 's3InputUri' a
**Compatibility with old behavior:** Disable the feature flag to use input and output path fields for s3 URI


### @aws-cdk/core:generateUniqueIdentifiersForTokenizedLists
### @aws-cdk/core:generateTokenAwareStringifyLogicalIdFromTokenValue

*When enabled, generate the Logical ID of the CDKJsonStringify Custom Resource from the Intrinsic's unresovled value.* (fix)

Expand Down
3 changes: 1 addition & 2 deletions packages/aws-cdk-lib/cx-api/lib/features.ts
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ export const ECS_REMOVE_DEFAULT_DEPLOYMENT_ALARM = '@aws-cdk/aws-ecs:removeDefau
export const LOG_API_RESPONSE_DATA_PROPERTY_TRUE_DEFAULT = '@aws-cdk/custom-resources:logApiResponseDataPropertyTrueDefault';
export const S3_KEEP_NOTIFICATION_IN_IMPORTED_BUCKET = '@aws-cdk/aws-s3:keepNotificationInImportedBucket';
export const USE_NEW_S3URI_PARAMETERS_FOR_BEDROCK_INVOKE_MODEL_TASK = '@aws-cdk/aws-stepfunctions-tasks:useNewS3UriParametersForBedrockInvokeModelTask';
export const TOKEN_AWARE_STRINGIFY_LOGICAL_ID_FROM_TOKEN_VALUE = '@aws-cdk/core:generateUniqueIdentifiersForTokenizedLists';
export const TOKEN_AWARE_STRINGIFY_LOGICAL_ID_FROM_TOKEN_VALUE = '@aws-cdk/core:generateTokenAwareStringifyLogicalIdFromTokenValue';

export const FLAGS: Record<string, FlagInfo> = {
//////////////////////////////////////////////////////////////////////
Expand Down Expand Up @@ -1158,7 +1158,6 @@ export const FLAGS: Record<string, FlagInfo> = {
which makes this logical ID no longer instantiation-order dependent.
`,
introducedIn: { v2: '2.158.0' },
defaults: { v2: true },
recommendedValue: true,
compatibilityWithOldBehaviorMd: 'When disabled, generate the Logical ID of the CDKJsonStringify Custom Resource from a counter.',
},
Expand Down

0 comments on commit 23a4901

Please sign in to comment.