Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lambda-python): add local bundling option #26062

Closed
wants to merge 4 commits into from

Conversation

polothy
Copy link
Contributor

@polothy polothy commented Jun 20, 2023

Docker bundling is slow, but sometimes necessary. This just gives the end user the option to bundle locally if they want to, but still have the option to fallback to the Docker bundling.

Related to #18290 - but I'm not sure if it closes it.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 20, 2023

@github-actions github-actions bot added the repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK label Jun 20, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team June 20, 2023 21:57
@github-actions github-actions bot added the p2 label Jun 20, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@polothy polothy changed the title feat(aws-lambda-python): add local bundling option feat(lambda-python): add local bundling option Jun 20, 2023
@polothy polothy force-pushed the python-local-bundling-option branch from e9f620d to 6b87157 Compare June 20, 2023 22:16
@polothy
Copy link
Contributor Author

polothy commented Jun 20, 2023

EDIT: I got something working - I ran it in us-east-1.

I got as far as running yarn integ --update-on-failed test/integ.function.js but I got worried about that it was doing to the AWS account and Ctr-C'ed out.

Running in parallel across regions: us-east-1, us-east-2, us-west-2

I don't have all those regions bootstrapped either.

@aws-cdk-automation aws-cdk-automation added the pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run label Jun 20, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review June 21, 2023 19:20

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 75b214b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. and removed pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run labels Jun 21, 2023
Copy link
Contributor

@corymhall corymhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@polothy thanks for getting this started! For the python local bundling feature we need to provide the bundling logic rather than expecting the user to provide it. Something like what is done with the lambda-nodejs construct.

@corymhall corymhall removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 26, 2023
@polothy
Copy link
Contributor Author

polothy commented Jun 26, 2023

I wasn't planning to take this PR that far. We can close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants