Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update cdk migrate command to allow for stack name input and additional languages #27134

Merged
merged 8 commits into from
Sep 14, 2023
Merged

chore: update cdk migrate command to allow for stack name input and additional languages #27134

merged 8 commits into from
Sep 14, 2023

Conversation

TheRealAmazonKendra
Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra commented Sep 13, 2023 •
edited
Loading

This change updates use of noctilucent to cdk-from-cfn and installs it from npm. It also adds some additional language support and stack renaming.

Not included in this PR:

  1. Automated testing - this PR has been manually tested and automated tests will be added in a subsequent PR.
  2. Go support - there are still some bugs to work out with go (in cdk-from-cfn) so implementation for it will be added after that's been worked out.
  3. The option to compress the app to a zip file
  4. The other TODOs listed in the migrate file.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team September 13, 2023 19:14
@github-actions github-actions bot added the p2 label Sep 13, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 13, 2023
@TheRealAmazonKendra
chore: update cdk migrate command to allow for stack name input and a…
619f018 
…dditional languages

This change updates use of noctilucent to cdk-from-cfn and installs it from npm. It also adds some additional language support and stack renaming.
aws-cdk-automation
aws-cdk-automation previously requested changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Sep 13, 2023
@TheRealAmazonKendra TheRealAmazonKendra force-pushed the TheRealAmazonKendra/migrate-stack-name branch from 4d98d72 to 619f018 Compare September 13, 2023 19:17
@TheRealAmazonKendra TheRealAmazonKendra added the pr/do-not-merge This PR should not be merged at this time. label Sep 13, 2023
@TheRealAmazonKendra TheRealAmazonKendra temporarily deployed to test-pipeline September 13, 2023 19:18 — with GitHub Actions Inactive
@TheRealAmazonKendra
Copy link
Contributor Author

Adding the do-not-merge so that this doesn't get approved before I'm ready for it to merge. Using this PR to run the integ tests against my changes.

@TheRealAmazonKendra TheRealAmazonKendra temporarily deployed to test-pipeline September 13, 2023 20:26 — with GitHub Actions Inactive
@TheRealAmazonKendra TheRealAmazonKendra temporarily deployed to test-pipeline September 13, 2023 21:54 — with GitHub Actions Inactive
@TheRealAmazonKendra TheRealAmazonKendra temporarily deployed to test-pipeline September 13, 2023 23:08 — with GitHub Actions Inactive
@TheRealAmazonKendra TheRealAmazonKendra temporarily deployed to test-pipeline September 14, 2023 01:20 — with GitHub Actions Inactive
@TheRealAmazonKendra TheRealAmazonKendra temporarily deployed to test-pipeline September 14, 2023 02:42 — with GitHub Actions Inactive
@TheRealAmazonKendra TheRealAmazonKendra added pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested and removed pr/do-not-merge This PR should not be merged at this time. labels Sep 14, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review September 14, 2023 03:52

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-cli-test-run This PR needs CLI tests run against it. labels Sep 14, 2023
@TheRealAmazonKendra
Copy link
Contributor Author

This PR is now ready to go.

kaizencc
kaizencc approved these changes Sep 14, 2023
View reviewed changes
packages/aws-cdk/lib/init.ts
@@ -247,10 +257,17 @@ export async function printAvailableTemplates(language?: string) {
}
}

export async function initializeProject(template: InitTemplate, language: string, canUseNetwork: boolean, generateOnly: boolean, workDir: string) {
async function initializeProject(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non binding comment: a lot of these functions have a ton of props, and given that its experimental why not change it so that it takes in a property bag initializeProjectOptions so that we can easily add properties to it in the future

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call out! I'll make this change in a future PR.

@mergify
Copy link
Contributor

mergify bot commented Sep 14, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 14, 2023
@mergify mergify bot temporarily deployed to test-pipeline September 14, 2023 19:36 Inactive
@aws-cdk-automation
Copy link
Collaborator

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 2ed530c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 123ab70 into main Sep 14, 2023
@mergify mergify bot deleted the TheRealAmazonKendra/migrate-stack-name branch September 14, 2023 19:59
@mergify
Copy link
Contributor

mergify bot commented Sep 14, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions github-actions bot mentioned this pull request Oct 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaizencc kaizencc kaizencc approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheRealAmazonKendra @aws-cdk-automation @kaizencc