Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: fix(ec2): fixing vpc endpoint pattern for ecr and ecr docker #31496

Merged
merged 1 commit into from
Sep 19, 2024
Merged

revert: fix(ec2): fixing vpc endpoint pattern for ecr and ecr docker #31496

merged 1 commit into from
Sep 19, 2024

Conversation

shikha372
Copy link
Contributor

@shikha372 shikha372 commented Sep 19, 2024 •
edited
Loading

Reverts #31434 to resolve #31492

@github-actions github-actions bot added the p2 label Sep 19, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team September 19, 2024 14:59
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 19, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@shikha372 shikha372 changed the title Revert "fix(ec2): fixing vpc endpoint pattern for ecr and ecr docker" "fix(ec2): revert fixing vpc endpoint pattern for ecr and ecr docker" Sep 19, 2024
@shikha372 shikha372 added the pr-linter/exempt-test The PR linter will not require test changes label Sep 19, 2024
@shikha372 shikha372 changed the title "fix(ec2): revert fixing vpc endpoint pattern for ecr and ecr docker" fix(ec2): revert fixing vpc endpoint pattern for ecr and ecr docker Sep 19, 2024
@shikha372 shikha372 added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Sep 19, 2024
@shikha372 shikha372 mentioned this pull request Sep 19, 2024
Closed
1 task
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b932b1b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@shikha372
Copy link
Contributor Author

Exemption Request : No change in integ test

@shikha372
Copy link
Contributor Author

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 19, 2024

update

☑️ Nothing to do

  • #commits-behind > 0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]
  • queue-position = -1 [📌 update requirement]

@shikha372 shikha372 marked this pull request as ready for review September 19, 2024 15:36
@shikha372 shikha372 changed the title fix(ec2): revert fixing vpc endpoint pattern for ecr and ecr docker revert(ec2) : "fix(ec2): revert fixing vpc endpoint pattern for ecr and ecr docker" Sep 19, 2024
shikha372 added a commit to cdklabs/aws-cdk-notices that referenced this pull request Sep 19, 2024
@shikha372
chore: notice for aws/aws-cdk#31496
501b0ab
@shikha372 shikha372 changed the title revert(ec2) : "fix(ec2): revert fixing vpc endpoint pattern for ecr and ecr docker" revert: fix(ec2): revert fixing vpc endpoint pattern for ecr and ecr docker Sep 19, 2024
@github-actions github-actions bot added bug This issue is a bug. p0 and removed p2 labels Sep 19, 2024
@shikha372 shikha372 changed the title revert: fix(ec2): revert fixing vpc endpoint pattern for ecr and ecr docker revert: fix(ec2): fixing vpc endpoint pattern for ecr and ecr docker Sep 19, 2024
@shikha372 shikha372 mentioned this pull request Sep 19, 2024
Merged
@aws-cdk-automation aws-cdk-automation dismissed their stale review September 19, 2024 15:49

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 19, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 17be13f into main Sep 19, 2024
47 of 56 checks passed
@mergify mergify bot deleted the revert-31434-shikagg/ecr_vpc_endpoint branch September 19, 2024 15:50
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jfuss jfuss jfuss approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. p0 pr-linter/exempt-test The PR linter will not require test changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

❗ NOTICE: aws-cdk-lib: Resolution error: Cannot find module '../../region-info/build-tools/fact-tables'
3 participants
@shikha372 @aws-cdk-automation @jfuss