Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ec2): instance support passing IAM instance profile #32073

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(ec2): instance support passing IAM instance profile #32073

wants to merge 2 commits into from

Conversation

phuhung273
Copy link

Issue # (if applicable)

Closes #8348

Reason for this change

  • Use only 1 IAM instance profile for multiple instances
  • Passing role create too many instance profile

Description of changes

  • ec2.Instance support instanceProfile param

Description of how you validated changes

  • unit test
  • integ test

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1 labels Nov 9, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team November 9, 2024 05:29
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5a18349
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1 pr/needs-maintainer-review This PR needs a review from a Core Team Member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow passing an IAM Instance Profile to ec2.Instance
2 participants
@phuhung273 @aws-cdk-automation