-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eks): add kubernetesGroups to AccessEntries #32074
feat(eks): add kubernetesGroups to AccessEntries #32074
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Exemption Request |
This is very much needed 🙏 |
…//github.com/markussiebert/aws-cdk into feat/accessentry-with-kubernetesGroups-30604
…//github.com/markussiebert/aws-cdk into feat/accessentry-with-kubernetesGroups-30604
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32074 +/- ##
=======================================
Coverage 80.64% 80.64%
=======================================
Files 107 107
Lines 6996 6996
Branches 1290 1290
=======================================
Hits 5642 5642
Misses 1175 1175
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
|
No on cares? So obvious feature ... ok will use escape hatches. I know how they work. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Hi @markussiebert , please add an integration test if possible. Let us know if you have any issues. |
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
Comments on closed issues and PRs are hard for our team to see. |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing ✅ A exemption request has been requested. Please wait for a maintainer's review. |
Issue # (if applicable)
Closes #30604
Reason for this change
Right now, it was not possible to set kubernetesGroups on AccessEntries and it was required to set AccessPolicies. Both were artificial limitiations, as Cloudformation nor the EKS Api behave like this.
With allowing kubernetesGroups, it's possible to define custom mappings of IAM Roles to (Cluster)RoleBindings.
Description of changes
No decisions, straight forward code
Description of how you validated changes
Created UnitTests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license